Dear Tom, Elm_Segment_Control_Item. Yeah I still want them to be fixed but Govindaraju agreed to use Elm_Segment_Item with Raster. I discussed this with Raster but Raster doesn't care the name that much. So I just let them go.
Btw, they fixed the code according to your review. I didn't see the code in detail. I checked the code very briefly and commented some and they're fixed except for Elm_Segment_Control_Item thing. And about doxy. Dear Prince, please refer Tom's comment and revise doxy? I hope this will be the last comment :) Thanks. Daniel Juyung Seo (SeoZ) On Mon, Apr 4, 2011 at 4:23 PM, Tom Hacohen <tom.haco...@partner.samsung.com > wrote: > Dear Daniel, > > First and foremost, didn't we decide to rename Elm_Segment_Item to > Elm_Segment_Control_Item? > > Second of all, doxy is not perfect. They declared @ingroup all over the > place, instead of opening curly-brackets in the docs, look at other > widgets/eina/eet/evas and you'll see what I'm talking about. No need to > the define the group everywhere. > > I'm too busy to continue the review ATM, but if you reviewed it and it's > ok, and they fixed all of the previous issues, it should be fine. > > -- > Tom. > > > On Thu, 2011-03-31 at 19:54 +0900, Daniel Juyung Seo wrote: > > Hello, I forward Prince's email again. > > Please find the attached email and attachment. > > Thanks. > > > > Daniel Juyung Seo (SeoZ) > > > > --------------------------------------------------------------- > > >From Prince. > > > > Please find in the attachment the the tar file of elm_segmentcontrol > widget > > patch for SVN upstreaming. > > Since I have to provide the images also so giving as a tar file. > > All review comments by Tom has been implemented. > > . > > Can you please post it to EFL community? > > > > Patch: New elementary widget: elm_segment_control. > > ==================== > > Authors: Govindaraju SM , Prince Kumar Dubey > > > > Change Log: New widget elm_segment_control. Segment Control Widget is > > a horizontal control made of multiple segment items together, each > > segment item are set to equal size, > > functioning similar to discrete two state button. Only one Segment item > > can be at selected state. > > ==================== > > > > > ------------------------------------------------------------------------------ > > Create and publish websites with WebMatrix > > Use the most popular FREE web apps or write code yourself; > > WebMatrix provides all the features you need to develop and > > publish your website. http://p.sf.net/sfu/ms-webmatrix-sf > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------------------------------ > Create and publish websites with WebMatrix > Use the most popular FREE web apps or write code yourself; > WebMatrix provides all the features you need to develop and > publish your website. http://p.sf.net/sfu/ms-webmatrix-sf > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
