On Mon, 4 Apr 2011 03:32:43 +0200 Leif Middelschulte <[email protected]> said:
> 2011/4/2 Mathieu Taillefumier <[email protected]>: > > Hey, > > > > do you want some specific tests about the patch ? > Well, basically feel free to test every function. I tested a couple of > functions, but cannot test every function since my IBM T60 display's > EDID doesn't comply with the standard. > > Find attached a little test program, which just test a subset of what > I implemented in terms of data extraction. For lazyness' sake you'll > have to pass it root windows and output ids. The instructions to do it > are given as comments in the code. > > BR, > > Leif > > *snap* > sorry, embedded patch was too long ;-) well it seems to find some info on my laptop's panel.though ascii name seems bad/corrupt. it smells badly of a non 0 terminated string. looks like other dangerous non-0 terminated string in serial too (fyi ascii name just is wrong from the edid - it has AUO\n m" so i think this needs to do some parsing and fixing up of such bad strings): EDID length: 128 EDID: 00ffffffffffff0006afec2000000000 01120103802213780a57559c5a549d26 1a505400000001010101010101010101 010101010101121b5643500026303020 340058c1100000180000000f00000000 00000000000000000020000000fe0041 554f0a202020202020202020000000fe 004231353658573032205630200a0046 Has a valid header: 1 Manufacturer name: AUO Display name: (null) ASCII name: AUO m EDID version: 1.3 Number of Extension blocks: 0 in general code is ok. i'd change a lot of shorts to ints, unsigned long to int, and formatting needs to match better. also it didnt compile as you used a Ecore_X_Randr_Edid_Aspect_Ratio_Preferred in the header when you only have Ecore_X_Randr_Edid_Aspect_Ratio defined, but a quick fix did that. as above - needs some string fixups and null terminations (never trust the edid content to do the 0 terminating for you). my laptop doesnt seem to give any useful information for: display name preferred aspect aspect ratios serial manufacturere serial number dpms (all of them) interface. not sure right now if this is just how the EDID info is or if your patch has problems. i dont have a xrandr capable display attached to a "good screen" to verify. but i i can put this in after some fixes as above. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Xperia(TM) PLAY It's a major breakthrough. An authentic gaming smartphone on the nation's most reliable network. And it wants your games. http://p.sf.net/sfu/verizon-sfdev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
