I'm ok with this concept.
Anybody else has a comment?

Let me give two comments.

1. How about checking sd->weel_disabled and disabled first.
    Genlist does this :) If you don't like it, never mind.

    if (!sd->wheel_disabled == disabled) return;
    if (disabled)
      xxxxxx
    else
      xxxxxx

2. Use EINA_TRUE/FALSE for Eina_Bool.
    I think bounce_animator, momentum_animator also have to be changed :)

    sd->wheel_disabled = EINA_FALSE;

Otherwise looks ok.
Thanks.

Daniel Juyung Seo (SeoZ)

On Wed, Apr 27, 2011 at 9:51 AM, sangho park <gouach...@gmail.com> wrote:

> Dear all,
>
> this patch is for enable / disable the default els_scroller's wheel
> control.
>
> when I use elm_map, map's default wheel control means zoom in / out.
> so enable / disable els_scroller's default wheel control feature is needed.
>
> map is also needed enable / disable default wheel control.
> if you review this patch, I'll apply elm_map at next time.
>
> Thanks.
> BR.
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today.  Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to