Regarding bullet 4: done, in svn, 58991. I tested it with your patches and it seems to work, please also update and make sure.
Thanks, Tom. On Thu, 2011-04-28 at 10:58 +0300, Tom Hacohen wrote: > Dear Shilpa, > > Here are my comments: > 1. Looking at the changes you did for elementary: I don't see why you > even need them. Just change the env var to EDJE_ENTRY_PASSWORD_SHOW_LAST > and skip all the things you had to do in elm... Makes no sense to have > those in ELM. By doing that you get the added value of supporting this > feature in edje (without elm) which is wanted anyway. > 2. Bullet #1 eliminates the need for > "entry_mode: PASSWORD_SHOW_LAST_INPUT;" You just need to set it as > password like it was, and merge the theme with the one of the regular > password. This will simplify some of your edje changes. > 3. I noticed you did a bunch of changes in edje (near preedit mostly), > what are they for? > 4. Regarding textblock: I understand why you did your change to > evas_textblock_node_format_remove_pair, but the change isn't the correct > way to handle this. I'm currently working on fixing this function, my > bad for forgetting about it. :P > > Please fix/explain the above comments and then I will review the patch > again. > > Thanks, > Tom. > > > On Thu, 2011-04-28 at 14:38 +0900, Daniel Juyung Seo wrote: > > Dear all, I forward Shilpaonkar Singh's entry patch to mailing list. > > Please find the attached mail and patch files. > > > > > > ------- Original Message ------- > > > > Sender : SHILPAONKAR SINGH<shilpa.si...@samsung.com> > > Date : Apr 27, 2011 22:22 (GMT+09:00) > > Title : Entry - [Password show last input] open source patch > > > > Hi Mr. Seo, > > > > Please find attached patches for last input show password feature. > > These patches are based on current SVN version - 58957. > > > > There is no special demo app for this feature, for testing purpose > > enviromental variable > > ELM_PASSWORD_SHOW_LAST_INPUT has to be set as shown below. > > export ELM_PASSWORD_SHOW_LAST_INPUT = 1 and then by clicking on > > entry_scrolled > > we can test password feature. > > > > I have also done a fix in evas_textblock_node_format_remove_pair function > > for this feature in the current svn version. > > Can you please push this patch to community as there are alot of changes > > happening in textblock level it would be better > > to push it soon to avoid rework. > > > > Thanks & Regards > > > > Shilpa Singh > > > > ------------------------------------------------------------------------------ > > WhatsUp Gold - Download Free Network Management Software > > The most intuitive, comprehensive, and cost-effective network > > management toolset available today. Delivers lowest initial > > acquisition cost and overall TCO of any competing solution. > > http://p.sf.net/sfu/whatsupgold-sd > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > WhatsUp Gold - Download Free Network Management Software > The most intuitive, comprehensive, and cost-effective network > management toolset available today. Delivers lowest initial > acquisition cost and overall TCO of any competing solution. > http://p.sf.net/sfu/whatsupgold-sd > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
