On Mon, 25 Apr 2011 19:01:09 +0900 Jihoon Kim <jihoon48....@samsung.com> said:
thanks! very muchly. :) in svn it is! (added changelog too for you) > Thank you for your valuable comment. > > I fixed the patch file and send again according to your advice. > > Would you please review it again? :) > > -----Original Message----- > From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] > Sent: Monday, April 25, 2011 5:15 PM > To: Jihoon Kim > Cc: enlightenment-devel@lists.sourceforge.net; 박세환 > Subject: Re: [E-devel] [PATCH] Add ecore_imf_context_autocapital_type_{set, > get}, ecore_imf_context_prediction_allow_{set, get} > > On Wed, 20 Apr 2011 16:14:04 +0900 Jihoon Kim <jihoon48....@samsung.com> > said: > > > Hello, EFL developers. > > > > To support the autocapitalization feature, I'd like to add > > ecore_imf_context_autocapital_type_{set,get} API. > > I will implement the autocapital feature in immodule, so the immodule > > should know the autocapitalization type. > > This API is for letting immodule know the autocapitalization type. > > > > In addition, ecore_imf_context_prediction_allow_set API is used to set > > whether the IM context should allow to use the text prediction. > > > > Would you please review this patch? > > one comment? > > + Eina_Bool allow_prediction; > > any reason u dont make it a bitfield? ie allow_prediction : 1 > also why not put it at struct end to keep struct smaller? avoid alignment > padding issues. > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
