On 05/11/2011 02:39 AM, s...@tango.flipp.net wrote:
>> Log:
>> E17: When searching for an icon in the fdo theme, if we do not find it
>>    in the current theme, check some fallback icon themes (so there is
>>    less chance of a menu item having no icon).
>
> Oh! This is so wrong! You completely trash the efreet cache by doing this.
> All themes inherit from hicolor anyway, and Human inherits from gnome. And
> if I don't remember wrong, default isn't an icon theme.
>
> S.
>
Hmm, then this needs to be fixed in elm also, because this is exactly 
how elm finds fdo icons also.

If it is Truly wrong, then I will revert it.....

dh

>>
>>
>>
>> Author:       devilhorns
>> Date:         2011-05-10 22:06:08 -0700 (Tue, 10 May 2011)
>> New Revision: 59314
>> Trac:         http://trac.enlightenment.org/e/changeset/59314
>>
>> Modified:
>>    trunk/e/src/bin/e_utils.c
>>
>> Modified: trunk/e/src/bin/e_utils.c
>> ===================================================================
>> --- trunk/e/src/bin/e_utils.c        2011-05-11 04:56:42 UTC (rev 59313)
>> +++ trunk/e/src/bin/e_utils.c        2011-05-11 05:06:08 UTC (rev 59314)
>> @@ -450,8 +450,25 @@
>>      size = e_icon_scale_size_get(obj);
>>      if (size<  16) size = 16;
>>      size = e_util_icon_size_normalize(size * e_scale);
>> +
>>      path = efreet_icon_path_find(e_config->icon_theme, icon, size);
>> +   if (!path)
>> +     {
>> +        path = efreet_icon_path_find("default", icon, size);
>> +        if (!path)
>> +          {
>> +             path = efreet_icon_path_find("hicolor", icon, size);
>> +             if (!path)
>> +               {
>> +                  path = efreet_icon_path_find("gnome", icon, size);
>> +                  if (!path)
>> +                    path = efreet_icon_path_find("Human", icon, size);
>> +               }
>> +          }
>> +     }
>> +
>>      if (!path) return 0;
>> +
>>      e_icon_file_set(obj, path);
>>      return 1;
>>   }


------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to