Wow.. This is good! I'm maintaining elm build issues with "-W -Wall -Wextra" options everyday. I thought that was enough but it's good to know "-Wshadow" :) So I'm gonna maintain elementary with that option to make it warning proof !!
Thanks. Daniel Juyung Seo (SeoZ) On Fri, May 20, 2011 at 4:02 PM, Vincent Torri <vto...@univ-evry.fr> wrote: > > > On Thu, 19 May 2011, Enlightenment SVN wrote: > >> Log: >> elementary / transit - removed unused variables. > > if you want to clean elm, i would suggest that you compile it with: > > -Wall -Wextra -Wshadow > > there is a bunch of warnings to clean up. Especially shadow variables. > > Of course, this is also valid for the other lib :p > > Vincent > >> >> >> >> Author: hermet >> Date: 2011-05-19 23:56:31 -0700 (Thu, 19 May 2011) >> New Revision: 59551 >> Trac: http://trac.enlightenment.org/e/changeset/59551 >> >> Modified: >> trunk/elementary/src/lib/elm_transit.c >> >> Modified: trunk/elementary/src/lib/elm_transit.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_transit.c 2011-05-20 06:51:05 UTC (rev >> 59550) >> +++ trunk/elementary/src/lib/elm_transit.c 2011-05-20 06:56:31 UTC (rev >> 59551) >> @@ -620,13 +620,10 @@ >> { >> ELM_TRANSIT_CHECK_OR_RETURN(transit); >> Evas_Object *obj; >> - Eina_List *elist; >> Elm_Obj_Data *obj_data; >> >> if (transit->event_enabled == enabled) return; >> - >> transit->event_enabled = !!enabled; >> - >> eina_hash_foreach(transit->objs_data_hash, _hash_foreach_pass_events_set, >> transit); >> } >> >> @@ -985,7 +982,6 @@ >> EAPI void >> elm_transit_objects_final_state_keep_set(Elm_Transit *transit, Eina_Bool >> state_keep) >> { >> - Eina_List *list; >> Evas_Object *obj; >> Elm_Obj_Data *obj_data; >> >> >> >> ------------------------------------------------------------------------------ >> What Every C/C++ and Fortran developer Should Know! >> Read this article and learn how Intel has extended the reach of its >> next-generation tools to help Windows* and Linux* C/C++ and Fortran >> developers boost performance applications - including clusters. >> http://p.sf.net/sfu/intel-dev2devmay >> _______________________________________________ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> > > ------------------------------------------------------------------------------ > What Every C/C++ and Fortran developer Should Know! > Read this article and learn how Intel has extended the reach of its > next-generation tools to help Windows* and Linux* C/C++ and Fortran > developers boost performance applications - including clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
