On Thu, Sep 9, 2010 at 4:08 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
>  lots of cleanups... actually tested! :)
>
>
> Author:       raster
> Date:         2010-09-09 00:08:10 -0700 (Thu, 09 Sep 2010)
> New Revision: 52030

>  static void
> -_evas_preload_thread_end(Evas_Preload_Pthread_Data *pth)
> +_evas_preload_thread_end(void *data)
>  {
> -   Evas_Preload_Pthread_Data *p;
> +   Evas_Preload_Pthread_Data *pth = data;
> +   Evas_Preload_Pthread_Data *p = NULL;
>
> -   if (pthread_join(pth->thread, (void **) &p) != 0)
> -     return ;
> -
> -   _evas_preload_thread = eina_list_remove(_evas_preload_thread, pth);
> +   if (pthread_join(pth->thread, (void **)&p) != 0) free(p);
>  }

Hello raster, I know this is old, but I can't understand it... why do
you only free the data struct on pthread_join error? Shouldn't you
free it always?

I can always get leaks on almost every call that I'm doing to
edje_object_preload() on my program. I can send you a test case if
necessary...

-- 
Rafael Antognolli
ProFUSION embedded systems
http://profusion.mobi

------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger. 
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today. 
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to