On Sat, Jun 4, 2011 at 9:42 AM, Rafael Antognolli <antogno...@profusion.mobi> wrote: > On Sat, Jun 4, 2011 at 6:47 AM, Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> wrote: >> On Sat, Jun 4, 2011 at 2:19 AM, Enlightenment SVN >> <no-re...@enlightenment.org> wrote: >>> >>> Log: >>> e_fm: move should compare both paths totally. >>> >>> Comparing just until the strlen(p2) won't allow to move an inner directory >>> to >>> a parent directory. >> ... >>> + (strncmp(p, p2, PATH_MAX) == 0) && >> >> so just strcmp() as using PATH_MAX brings no good other than an extra >> comparison during the match. > > Why not? If you try to move /tmp/outer/inner -> /tmp, the previous > comparison was being == 0, and now it returns something different (and > allows the move op).
read again. I mean your new patch is not the best solution, it should be: + (strcmp(p, p2) == 0) && -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
