Hello, belated review :) 1. Use Evas_Smart_Cb_Description for smart callbacks. I fixed it in SVN. http://trac.enlightenment.org/e/changeset/60014
2. Changed signal name. I changed reorder signal name from "elm,state,reorder_enabled" to "elm,state,reorder,enabled". This is more EFL-like I guess. I changed genlist's as well. Thanks. Daniel Juyung Seo (SeoZ) On Fri, Jun 3, 2011 at 4:13 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 03 Jun 2011 16:04:51 +0900 Jeonghyun Yun <jh0506....@samsung.com> > said: > > now THATS good stuff! you can see when it goes into reorder mode... yay! :) > nice! in svn! > >> Hello, >> >> I added theme stuff to handle the reorder mode. >> Please check this patch again. >> >> Thanks, raster. >> >> >> -----Original Message----- >> From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] >> Sent: Thursday, June 02, 2011 4:10 PM >> To: Jeonghyun Yun >> Cc: enlightenment-devel@lists.sourceforge.net >> Subject: Re: [E-devel] [Patch] elm_gengrid - added new feature : gengrid >> reorder mode >> >> On Mon, 30 May 2011 19:41:24 +0900 Jeonghyun Yun <jh0506....@samsung.com> >> said: >> >> this seems good. no theme stuff to handle the reorder mode change on the >> item >> tho.. shame :( >> >> > Dear All. >> > >> > I added a new feature "reorder mode" of gengrid refer to genlist reorder >> > mode. >> > >> > After set this reorder API, if user press an item (long press), the item >> can >> > be moved another position. >> > Then if the user releases the item, the item will be reordered in gengrid. >> > >> > Please review this patch. >> > >> > Thanks. >> > >> > [API] >> > ================================================================== >> > /** >> > * Set the reorder mode >> > * >> > * @param obj The Gengrid object >> > * @param reorder_mode The reorder mode >> > * (EINA_TRUE = on, EINA_FALSE = off) >> > * >> > * @ingroup Gengrid >> > */ >> > EAPI void >> > elm_gengrid_reorder_mode_set(Evas_Object *obj, Eina_Bool reorder_mode) >> > >> > /** >> > * Get the reorder mode >> > * >> > * @param obj The Gengrid object >> > * @return The reorder mode >> > * (EINA_TRUE = on, EINA_FALSE = off) >> > * >> > * @ingroup Gengrid >> > */ >> > EAPI Eina_Bool >> > elm_gengrid_reorder_mode_get(const Evas_Object *obj) >> > ================================================================== >> >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Simplify data backup and recovery for your virtual environment with vRanger. > Installation's a snap, and flexible recovery options mean your data is safe, > secure and there when you need it. Discover what all the cheering's about. > Get your free trial download today. > http://p.sf.net/sfu/quest-dev2dev2 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
