On Tue, Jun 7, 2011 at 8:41 AM, Vincent Torri <vto...@univ-evry.fr> wrote:
> On Tue, 7 Jun 2011, Ulrich Eckhardt wrote:
>> I've been reading commits recently, and found a small buglet committed in
>> revision 59823. The line
>>
>> ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE, "ecore_pipe_read_close");
>>
>> should probably contain the function name as string, but it doesn't for the
>> freeze/thaw functions.
>
> in svn, thanks.
>
> I'm wondering why __FUNCTION__ is not used, though. We could then define a
> macro:
>
> #define ECORE_PIPE_CHECK(p) \
> if (!ECORE_MAGIC_CHECK((p), ECORE_MAGIC_PIPE)) \
> { \
> ECORE_MAGIC_FAIL((p), ECORE_MAGIC_PIPE, __FUNCTION__); \
> return; \
> }
>
> It would be less error-prone. And actually, that could be used in a lot of
> places other than ecore_pipe.
In fact we should move to Eina Magic that already do all that stuff properly.
--
Cedric BAIL
------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
