On Wed, 15 Jun 2011 07:55:27 +0200 (CEST) Vincent Torri <vto...@univ-evry.fr> wrote:
> > > On Wed, 15 Jun 2011, Mike Blumenkrantz wrote: > > > On Wed, 15 Jun 2011 07:34:08 +0200 > > Ulrich Eckhardt <dooms...@knuut.de> wrote: > > > >> Hi! > >> > >> If you start edje_player or edje_inspector with a path to a file that > >> doesn't exist you get a bogus error message saying that the file doesn't > >> contain any groups. The attached patch uses access() to check if the > >> program can read the file, giving a sensible error message if not. > >> > >> I have checked the other utilities there, too, and they work, with the > >> exception of edje_external_inspector. I'm not sure how this one works at > >> all, but it seems not to take a file but a list of modules, maybe someone > >> with greater insight can take a look at that. > >> > >> Going through things installed under bin, I'll take a look if those behave > >> properly and create patches for those, too, if this one is okay. > >> > >> Cheers! > >> > >> Uli > > I like the idea of better error messages, but using access creates a > > permissions loophole where the file could be switched between access() and > > open(). You should probably check it another way. > > ecore_file_exists ? > > Vincent same loophole. I suppose it's not really that big of a deal... -- Mike Blumenkrantz Zentific: Coding in binary since '10. ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
