Dear junghyun. I pushed it instead of raster
And you don't need to append '.txt' after the extension anymore. Thanks. from hermet -------- Original message -------- Subject: Re: [E-devel] [Patch] elm_gengrid bug patch From: Jeonghyun Yun <jh0506....@samsung.com> To: "'Carsten Haitzler (The Rasterman)'" <ras...@rasterman.com> CC: enlightenment-devel@lists.sourceforge.net >I resubmit the patch file. >Thank you. > >-----Original Message----- >From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] >Sent: Monday, February 28, 2011 12:14 AM >To: Jeonghyun Yun >Cc: enlightenment-devel@lists.sourceforge.net >Subject: Re: [E-devel] [Patch] elm_gengrid bug patch > >On Fri, 25 Feb 2011 13:42:21 +0900 Jeonghyun Yun <jh0506....@samsung.com> >said: > >> Hello. >> >> I attached the modified patch about calc_job problem. >> >> When I tested gengrid, sometimes gengrid renderd two times in different >> shape in a moment. >> So I checked gengrid code, I found cause in calc_job function. >> >> calc_job added to ecore job after elm_gengrid_item_size_set and >> elm_gengrid_item_append(,prepend,insert_before,insert_after) and etc. >> Sometimes pan_smart's cvw and cvh is 0 at this time. >> >> I think, No need to calc_job when pan_smart's cvw and cvh is 0. >> >> Please check about this patch. > >ok - but your formatting/code style are a bit off: > > if (cvw != 0 || cvh != 0) >should be > if ((cvw != 0) || (cvh != 0)) > >resubmit? :) > >-- >------------- Codito, ergo sum - "I code, therefore I am" -------------- >The Rasterman (Carsten Haitzler) ras...@rasterman.com > >------------------------------------------------------------------------------ >Free Software Download: Index, Search & Analyze Logs and other IT data in >Real-Time with Splunk. Collect, index and harness all the fast moving IT data >generated by your applications, servers and devices whether physical, virtual >or in the cloud. Deliver compliance at lower cost and gain new business >insights. http://p.sf.net/sfu/splunk-dev2dev >_______________________________________________ >enlightenment-devel mailing list >enlightenment-devel@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
