On Thu, Jun 30, 2011 at 8:06 PM, Rafael Antognolli <antogno...@profusion.mobi> wrote: > On Thu, Jun 30, 2011 at 2:59 PM, Rafael Antognolli > <antogno...@profusion.mobi> wrote: >> I'm documenting the emotion API right now, and just noticed the following >> API: >> >> emotion_object_module_option_set() >> emotion_object_audio_mute_set() >> emotion_object_video_mute_set() >> >> So, what's the difference between them? Is module_option_set() >> intended to be extended in the future, allowing more options than just >> audio and video mute? >> >> From what I can see in the code, audio and video mute_set call the >> module->mute_set(), which does the same as module_option_set() is >> doing. So, is it possible to deprecate one of these APIs? Or we really >> need them? > > Actually, looking again at the code, the > emotion_object_module_option_set() function seems bogus, since it only > set the audio and video to mute if the given option is "off", but does > nothing if anything else is given as parameter. I vote to deprecate > this function.
I didn't start to cleanup the API of emotion, yet. But I vote for the death of that API now ! -- Cedric BAIL ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
