On Wed, 29 Jun 2011 16:01:06 +0200 "Libor Zoubek" <lzou...@jezzovo.net> said:
> Hi, devs > > I've reported a bug http://trac.enlightenment.org/e/ticket/775 > Please review/apply attached patch that fixes above bug. > > Thanks > > cheers, > > Libor Zoubek > > P.S. I am a happy e-user and this is my 1st attempt to contribute cool!... patch kind of good. it moves forward to a new version (1.2) BUT... your patch makes edbus daemon still say it does 0.9 but the spec you are making it move to is 1.2 (more strings). so E_NOTIFICATION_DAEMON_VERSION and E_NOTIFICATION_DAEMON_SUPPORTS_SPEC_VERSION should say "1.2"... also e_notify_unmarshal_get_server_information_return doesnt seem to be backwards compatible - ie it doesnt handle "sss" vs "ssss" signature (extra version string on the end). we'd be pretty bad breaking compat to 0.9. so we should do "if "sss" > handle 0.9, else if "ssss" > handle 1.2" like logic there. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
