2011/7/11 Christian Apeltauer <c.apelta...@gmx.de>

> On Fri, 1 Jul 2011 18:54:32 +0200
> Christian Apeltauer <c.apelta...@gmx.de> wrote:
>
> > Another correction should be done to elsa/src/daemon/elsa.c:
> > diff -Naur elsa/src/daemon/elsa.c elsa.neu//src/daemon/elsa.c
> > --- elsa/src/daemon/elsa.c    2011-06-26 12:25:38.000000000 +0200
> > +++ elsa.neu//src/daemon/elsa.c       2011-06-26 13:21:18.000000000
> > +0200 @@ -290,6 +290,7 @@
> >     elsa_pam_shutdown();
> >     ecore_shutdown();
> >     elsa_close_log();
> > +   _remove_lock(); //_remove_lock() still uses elsa_config
> >     elsa_config_shutdown();
> >     if (elsa_session_logged_get())
> >       {
> > @@ -299,7 +300,7 @@
> >          putenv(buf);
> >          _elsa_wait();
> >       }
> > -   _remove_lock();
> > +   //_remove_lock(); // elsa_config is already freed here
> >     return 0;
> >  }
> >
>
> Dear developpers,
>  the patch to elsa.c was applied only partially. What I proposed was
> moving _remove_lock() from after elsa_config_shutdown() to before
> elsa_config_shutdown since _remove_lock() still uses elsa_config
> which is freed by elsa_config_shutdown. With _remove_lock() now removed
> altogether, /var/un/elsa.pid does not get deleted after successful
> login and prevents elsa from coming up again after logout.
>  Best regards
>    Christian
>
>
> --
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

This code isn't executed if the user are successfully logged... elsa_wait
doesn't exit, but wait :P.
I must clean the place here. I have a patch for that, but I can't commit it
right now, too many change. I plan fix this in few days with many new
features.

--
Michaƫl Bouchaud
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to