On Thu, Jul 28, 2011 at 1:44 PM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
> elementary: fix fileselector expandable mode with eio.

I think you just broke it *without* eio...

> Author:       cedric
> Date:         2011-07-28 09:44:10 -0700 (Thu, 28 Jul 2011)
> New Revision: 61864
> Trac:         http://trac.enlightenment.org/e/changeset/61864
>
> Modified:
>  trunk/elementary/src/lib/elc_fileselector.c
>
> Modified: trunk/elementary/src/lib/elc_fileselector.c
> ===================================================================
> --- trunk/elementary/src/lib/elc_fileselector.c 2011-07-28 16:43:15 UTC (rev 
> 61863)
> +++ trunk/elementary/src/lib/elc_fileselector.c 2011-07-28 16:44:10 UTC (rev 
> 61864)
> @@ -649,9 +649,14 @@
>    _signal_first(wr);
>
>    if (wr->wd->mode == ELM_FILESELECTOR_LIST)
> -     elm_genlist_item_direct_sorted_insert(wr->wd->files_list, 
> eio_file_associate_find(handler, "type/list"),
> -                                           
> eina_stringshare_ref(eio_file_associate_find(handler, "filename")),
> -                                           wr->parent, 
> ELM_GENLIST_ITEM_NONE, _file_list_cmp, NULL, NULL);
> +     {
> +        Eina_Bool is_dir = (eio_file_associate_find(handler, "type/list") == 
> &list_itc[ELM_DIRECTORY]);
> +
> +        elm_genlist_item_direct_sorted_insert(wr->wd->files_list, 
> eio_file_associate_find(handler, "type/list"),
> +                                              
> eina_stringshare_ref(eio_file_associate_find(handler, "filename")),
> +                                              wr->parent, wr->wd->expand && 
> is_dir ? ELM_GENLIST_ITEM_SUBITEMS : ELM_GENLIST_ITEM_NONE,
> +                                              _file_list_cmp, NULL, NULL);
> +     }
>    else if (wr->wd->mode == ELM_FILESELECTOR_GRID)
>      elm_gengrid_item_direct_sorted_insert(wr->wd->files_grid, 
> eio_file_associate_find(handler, "type/grid"),
>                                            
> eina_stringshare_ref(eio_file_associate_find(handler, "filename")),
> @@ -675,9 +680,7 @@
>
>    _signal_first(wr);
>
> -#ifdef HAVE_EIO
>    wr->wd->current = NULL;
> -#endif
>    _widget_request_cleanup(wr);
>  }
>
> @@ -686,10 +689,8 @@
>  {
>    Widget_Request *wr = data;
>
> -#ifdef HAVE_EIO
>    if (wr->wd->current == handler)
>      wr->wd->current = NULL;
> -#endif
>    _widget_request_cleanup(wr);
>  }
>
> @@ -711,6 +712,7 @@
>  #endif
>
>    if (!wd) return;
>>>> +   if (wd->expand && wd->current) return ;

And the above line seems to be the problem (won't change it though,
since I'm not digging into the problem).

>  #ifndef HAVE_EIO
>    if (!ecore_file_is_dir(path)) return ;
>    it = eina_file_stat_ls(path);
>
>
> ------------------------------------------------------------------------------
> Got Input?   Slashdot Needs You.
> Take our quick survey online.  Come on, we don't ask for help often.
> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
> http://p.sf.net/sfu/slashdot-survey
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>



-- 
Rafael Antognolli
ProFUSION embedded systems
http://profusion.mobi

------------------------------------------------------------------------------
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to