On Thu, 4 Aug 2011, Vincent Torri wrote:

>> 2. evas_font_dirr.diff
>> strndup is GNU extension, anyhow, I'm not sure the 'tmp' is necessary stuff.
>> If it is.. strndup() should be modified by using eina_unicode_strndup()
>
> i don't know if it is a windows specific problem.

tmp is needed, I think. Maybe you have found a bug and in

FcPatternAddString (p_nm, FC_FAMILY, (FcChar8*) start);

'start' should be replaced by 'tmp'. I don't know that code, though.

The purpose seems to split a string with the ',' token or 
something like that. So the duplication of the string would be needed.

In that case, a malloc + memcpy should be sufficient:

tmp = (char *)malloc(end - start + 1);
if (tmp)
{
   memcpy(tmp, start, end - start);
   tmp[end - start] = '\0';
   FcPatternAddString (p_nm, FC_FAMILY, (FcChar8*)tmp);
   free(tmp);
}

(but this code is useful only if 'start' should be replaced by 'tmp')

Vincent

------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to