Thanks but I as said this might be a big change for applications. We'll see what's happening.
Thanks. Daniel Juyung Seo (SeoZ) On Mon, Aug 8, 2011 at 7:32 PM, Enlightenment SVN <no-re...@enlightenment.org> wrote: > Log: > we really should focus when we release mouse AND on_hold is... NOT > set. happy happy joy joy. > > > > Author: raster > Date: 2011-08-08 03:32:32 -0700 (Mon, 08 Aug 2011) > New Revision: 62197 > Trac: http://trac.enlightenment.org/e/changeset/62197 > > Modified: > trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h > trunk/elementary/src/lib/elm_win.c > > Modified: trunk/elementary/src/lib/elm_widget.c > =================================================================== > --- trunk/elementary/src/lib/elm_widget.c 2011-08-08 09:44:22 UTC (rev > 62196) > +++ trunk/elementary/src/lib/elm_widget.c 2011-08-08 10:32:32 UTC (rev > 62197) > @@ -233,12 +233,14 @@ > } > > static void > -_sub_obj_mouse_down(void *data __UNUSED__, > - Evas *e __UNUSED__, > - Evas_Object *obj, > - void *event_info __UNUSED__) > +_sub_obj_mouse_up(void *data __UNUSED__, > + Evas *e __UNUSED__, > + Evas_Object *obj, > + void *event_info) > { > - elm_widget_focus_mouse_down_handle(obj); > + Evas_Event_Mouse_Up *ev = event_info; > + if (!(ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD)) > + elm_widget_focus_mouse_up_handle(obj); > } > > static void > @@ -986,8 +988,8 @@ > } > evas_object_event_callback_del_full(sd->resize_obj, EVAS_CALLBACK_DEL, > _sub_obj_del, sd); > - evas_object_event_callback_del_full(sd->resize_obj, > EVAS_CALLBACK_MOUSE_DOWN, > - _sub_obj_mouse_down, sd); > + evas_object_event_callback_del_full(sd->resize_obj, > EVAS_CALLBACK_MOUSE_UP, > + _sub_obj_mouse_up, sd); > evas_object_smart_member_del(sd->resize_obj); > if (_elm_widget_is(sd->resize_obj)) > { > @@ -1007,8 +1009,8 @@ > } > evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_DEL, > _sub_obj_del, sd); > - evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_MOUSE_DOWN, > - _sub_obj_mouse_down, sd); > + evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_MOUSE_UP, > + _sub_obj_mouse_up, sd); > evas_object_smart_member_del(sobj); > if (_elm_widget_is(sobj)) > { > @@ -1030,8 +1032,8 @@ > evas_object_smart_member_add(sobj, obj); > evas_object_event_callback_add(sobj, EVAS_CALLBACK_DEL, > _sub_obj_del, sd); > - evas_object_event_callback_add(sobj, EVAS_CALLBACK_MOUSE_DOWN, > - _sub_obj_mouse_down, sd); > + evas_object_event_callback_add(sobj, EVAS_CALLBACK_MOUSE_UP, > + _sub_obj_mouse_up, sd); > _smart_reconfigure(sd); > evas_object_data_set(sobj, "elm-parent", obj); > evas_object_smart_callback_call(obj, "sub-object-add", sobj); > @@ -2445,7 +2447,7 @@ > } > > EAPI void > -elm_widget_focus_mouse_down_handle(Evas_Object *obj) > +elm_widget_focus_mouse_up_handle(Evas_Object *obj) > { > Evas_Object *o = obj; > do > > Modified: trunk/elementary/src/lib/elm_widget.h > =================================================================== > --- trunk/elementary/src/lib/elm_widget.h 2011-08-08 09:44:22 UTC (rev > 62196) > +++ trunk/elementary/src/lib/elm_widget.h 2011-08-08 10:32:32 UTC (rev > 62197) > @@ -341,7 +341,7 @@ > EAPI Eina_List *elm_widget_stringlist_get(const char *str); > EAPI void elm_widget_stringlist_free(Eina_List *list); > EAPI void elm_widget_focus_hide_handle(Evas_Object *obj); > -EAPI void elm_widget_focus_mouse_down_handle(Evas_Object *obj); > +EAPI void elm_widget_focus_mouse_up_handle(Evas_Object *obj); > EAPI void elm_widget_focus_tree_unfocusable_handle(Evas_Object > *obj); > EAPI void elm_widget_focus_disabled_handle(Evas_Object *obj); > EAPI void elm_widget_text_part_set(Evas_Object *obj, const char > *part, const char *label); > > Modified: trunk/elementary/src/lib/elm_win.c > =================================================================== > --- trunk/elementary/src/lib/elm_win.c 2011-08-08 09:44:22 UTC (rev 62196) > +++ trunk/elementary/src/lib/elm_win.c 2011-08-08 10:32:32 UTC (rev 62197) > @@ -1277,13 +1277,15 @@ > } > > static void > -_win_img_mouse_down(void *data, > - Evas *e __UNUSED__, > - Evas_Object *obj __UNUSED__, > - void *event_info __UNUSED__) > +_win_img_mouse_up(void *data, > + Evas *e __UNUSED__, > + Evas_Object *obj __UNUSED__, > + void *event_info) > { > Elm_Win *win = data; > - elm_widget_focus_mouse_down_handle(win->win_obj); > + Evas_Event_Mouse_Up *ev = event_info; > + if (!(ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD)) > + elm_widget_focus_mouse_up_handle(win->win_obj); > } > > static void > @@ -1316,8 +1318,8 @@ > > evas_object_event_callback_add(win->img_obj, EVAS_CALLBACK_HIDE, > _win_img_hide, win); > - evas_object_event_callback_add(win->img_obj, EVAS_CALLBACK_MOUSE_DOWN, > - _win_img_mouse_down, win); > + evas_object_event_callback_add(win->img_obj, EVAS_CALLBACK_MOUSE_UP, > + _win_img_mouse_up, win); > evas_object_event_callback_add(win->img_obj, EVAS_CALLBACK_FOCUS_IN, > _win_img_focus_in, win); > evas_object_event_callback_add(win->img_obj, EVAS_CALLBACK_FOCUS_OUT, > > > ------------------------------------------------------------------------------ > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > The must-attend event for mobile developers. Connect with experts. > Get tools for creating Super Apps. See the latest technologies. > Sessions, hands-on labs, demos & much more. Register early & save! > http://p.sf.net/sfu/rim-blackberry-1 > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
