Hi, here is my opinion.
1. how about changing the signal names to ones more explicitly ?
"elm,state,show,up"
"elm,state,show,down"
"elm,state,show,right"
"elm,state,show,left"
I guess hide could be added also later.
2. _transition_adjust
I don't like that name. Since those signals are not only for transitions but
also any other actions.
How about just _show_signal_emit ?
3. edje_object_signal_emit(wd->base, "elm,state,show", "elm"); in the
_ctxpopup_show function
looks useless call. doesnt' it?
------------------------------------
Let's run together for the best moment!
-Regards, Hermet-
-----Original Message-----
From: "cnook"<kimci...@gmail.com>
To: "EFL"<enlightenment-devel@lists.sourceforge.net>
Cc:
Sent: 11-08-22(월) 13:35:02
Subject: [E-devel] [Patch] elc_ctxpopup, add transition
Dear All, Hello!
The transition effect is added to the ctxpopup when it comes.
Please review the attached patch. Thanks always!
Sincerely,
Shinwoo Kim.
------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model
configuration take the hassle out of deploying and managing Subversion and
the tools developers use with it. Learn more about uberSVN and get a free
download at: http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model
configuration take the hassle out of deploying and managing Subversion and
the tools developers use with it. Learn more about uberSVN and get a free
download at: http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
