On Thu, 25 Aug 2011 02:17:53 +0900 Jiyoun Park <[email protected]> said:
> > Hello. > > 1. _pool_tex_dynamic_new function, it didnt set pt to NULL when > secsym_eglCreateImage function failed. > In this case, it returns wrong pt pointer and it has possibility to make > crash. > So I add free pt code and return NULL code into _pool_tex_dynamic_new > function. > > 2. I modified eng_image_data_get of gl engine. > > If Evas_GL_Image's texture creation failed and evas_gl_image's cache image > was droped, > Im->im can be NULL. So I add check code. > Example: evas_gl_common_image_content_hint_set > 1) EVAS_IMAGE_CONTENT_HINT_DYNAMIC , it drop cache image > 2) if evas_gl_common_texture_dynamic_new failed > 3) then, im->im =NULL, im->tex=NULL > In this situation, if application call's evas_object_image_data_get > function, > It make crash in evas_cache_image_load_data function. > > 3. I think function's related with evas_object's engine data have to be > return NULL if it failed. > If function's returns null, evas object code can handle error more easily. > But evas object's code was implemented differently each case. > Does my suggestion right? > I add engine data null check code to evas_object_image based on upper > consumtion. > If it is wrong , the patch code related with evas object image have to be > removed. > If it is right , I will survey other evas object type also. > > Thanks. no - thank YOU... you're right. thats a possible bug if texture allocation fails (out of mem/texture memory space). not handled properly. indeed. in svn it is! -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
