On 28/08/11 09:35, Vincent Torri wrote: > > > On Sat, 27 Aug 2011, Enlightenment SVN wrote: > >> Log: >> seriously guys. >> null checks. >> why are there still functions that don't have them after we've hit 1.0? > > backport ? > >> >> >> Author: discomfitor >> Date: 2011-08-27 23:30:51 -0700 (Sat, 27 Aug 2011) >> New Revision: 62900 >> Trac: http://trac.enlightenment.org/e/changeset/62900 >> >> Modified: >> trunk/eina/src/lib/eina_file.c >> >> Modified: trunk/eina/src/lib/eina_file.c >> =================================================================== >> --- trunk/eina/src/lib/eina_file.c 2011-08-28 05:00:29 UTC (rev 62899) >> +++ trunk/eina/src/lib/eina_file.c 2011-08-28 06:30:51 UTC (rev 62900) >> @@ -832,6 +832,7 @@ >> EAPI void >> eina_file_close(Eina_File *file) >> { >> + if (!file) return; >> eina_lock_take(&file->lock); >> file->refcount--; >> eina_lock_release(&file->lock); >> @@ -843,18 +844,21 @@ >> EAPI size_t >> eina_file_size_get(Eina_File *file) >> { >> + if (!file) return 0; >> return file->length; >> } >> >> EAPI time_t >> eina_file_mtime_get(Eina_File *file) >> { >> + if (!file) return 0; >> return file->mtime; >> } >> >> EAPI const char * >> eina_file_filename_get(Eina_File *file) >> { >> + if (!file) return NULL; >> return file->filename; >> }
Do we really want/need those useless checks? I think it's a shame to litter our whole API with null checks that should be up to the user anyway. -- Tom. ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
