On Fri, 2 Sep 2011, Hyoyoung Chang wrote:
> Yeap. So do you agree to re-factor about replacing 'new' keyword generally, we must not use c++ keywords or operators (class, this, new, delete, etc...). I also already said that i agreed. and forward enum declaration? i already suggested a cleaner solution than in the original patch (which is used in other headers, btw (see Evas.h, evas_common.h, etc...) but i would like 2 patches. Note that that stuff is not windows specific. So other people can comment too Vincent > >> -----Original Message----- >> From: Vincent Torri [mailto:vto...@univ-evry.fr] >> Sent: Friday, September 02, 2011 5:34 PM >> To: Enlightenment developer list >> Subject: Re: [E-devel] [Patch] Build on Windows - Build Error >> >> >> >> On Fri, 2 Sep 2011, Hyoyoung Chang wrote: >> >>> >>> >>>> -----Original Message----- >>>> From: Vincent Torri [mailto:vto...@univ-evry.fr] >>>> Sent: Friday, September 02, 2011 4:12 PM >>>> To: Enlightenment developer list >>>> Subject: Re: [E-devel] [Patch] Build on Windows - Build Error >>>> >>>> >>>> >>>> On Fri, 2 Sep 2011, cnook wrote: >>>> >>>>> Dear All, Hello! >>>>> >>>>> I have tried to build EFL on Windows 7 and met a problem when I had >>>> build >>>>> evas_ddraw_buffer.cpp >>>>> >>>>> evas_ddraw_buffer.cpp includes its evas_engine.h >>>>> And evas_engine.h includes evas_common_soft16.h that includes >>>> evas_private.h >>>>> finally. >>>>> (evas_ddraw_buffer.cpp -> evas_engine.h -> evas_common_soft16.h -> >>>>> evas_private.h) >>>>> >>>>> >>>>> g++ is used for compile the evas_ddraw_buffer.cpp. >>>>> it gives some error message as the followings. >>>>> >>>>> 1) evas_prevate.h:50:14: error: use of enum '_Evas_Font_Style' without >>>>> previous declaration >>>>> you would be able to test using gcc and g++ to compile following >>> code. >>>>> g++ will give error message as above. >>>>> #include <stdio.h> >>>>> typedef enum _myenum myenum; >>>>> enum _myenum >>>>> { >>>>> A, B, C >>>>> }; >>>>> int main() >>>>> { >>>>> printf("%d\n", B); >>>>> return 0; >>>>> } >>>> >>>> using typedef enum _foo >>>> { *** } foo; >>>> >>>> would be cleaner. I'm wondering if the c++ standard forbid such >>>> construction >>> >>> I think cnook's message is ambiguous. >>> The problem is enum can't be forward declared in c++(unless c++0x) >>> Refer this : >>> http://stackoverflow.com/questions/71416/forward-declaring-an-enum-in-c >> >> that's exactly the link i found :-) >> >> Vincent >> >>> I think it's better to re-align some enums and structure in >> evas_private.h >>> >>>> >>>>> >>>>> 2) evas_prevate.h:651:14: error: expected unqualified-id before 'new' >>>>> you would be able to test using gcc and g++ to compile following >>> code. >>>>> g++ will give error message. >>>>> #include <stdio.h> >>>>> struct ex1 >>>>> { >>>>> int new; >>>>> }; >>>>> int main() >>>>> { >>>>> struct ex1 ev; >>>>> ev.new = 9; >>>>> printf("%d\n", ev.new); >>>>> return 0; >>>>> } >>>> >>>> no problem for me >>> >>> Is it compiled for your c++ compiler? >>> I'm using g++(4.3,4.4,4.5) but it complains about 'new' keyword. >>> What's your cpp compiler, version and given options? >>> >>>> >>>>> Anyhow I have attached patch to resolve this issue. >>>>> Please review this and give your opinion. Thanks. >>>> >>>> provide 2 patches >>>> >>>> Vincent >>>> >>>> ----------------------------------------------------------------------- >> --- >>>> ---- >>>> Special Offer -- Download ArcSight Logger for FREE! >>>> Finally, a world-class log management solution at an even better >>>> price-free! And you'll get a free "Love Thy Logs" t-shirt when you >>>> download Logger. Secure your free ArcSight Logger TODAY! >>>> http://p.sf.net/sfu/arcsisghtdev2dev >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> enlightenment-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> >>> ------------------------------------------------------------------------ >> ------ >>> Special Offer -- Download ArcSight Logger for FREE! >>> Finally, a world-class log management solution at an even better >>> price-free! And you'll get a free "Love Thy Logs" t-shirt when you >>> download Logger. Secure your free ArcSight Logger TODAY! >>> http://p.sf.net/sfu/arcsisghtdev2dev >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> >> >> -------------------------------------------------------------------------- >> ---- >> Special Offer -- Download ArcSight Logger for FREE! >> Finally, a world-class log management solution at an even better >> price-free! And you'll get a free "Love Thy Logs" t-shirt when you >> download Logger. Secure your free ArcSight Logger TODAY! >> http://p.sf.net/sfu/arcsisghtdev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
