On Mon, Sep 5, 2011 at 2:22 PM, Bruno Dilly <bdi...@profusion.mobi> wrote: > On Mon, Sep 5, 2011 at 6:48 AM, Youness Alaoui > <kakar...@kakaroto.homelinux.net> wrote: >> Hi all, >> >> As most people in #e.fr know, for the past week, I've been porting the EFL >> to the PS3, and during my work I've stumbled across a few bugs/issues with >> the existing code that needed fixing (and which was unrelated to the PS3 >> port). > > I didn't know about it, really cool! =) > >> I've made a git clone of the svn and I've pushed my changes to my git >> remote. >> Cedric asked me to send an email with the patches, I would prefer for the >> patches to be reviewed on github since you can comment on individual lines >> and commits making the review process much easier. >> If you insist I can make them into patch files and send them over by mail, >> but I'd rather not. >> You can view my commits here : >> https://github.com/kakaroto/e17/commits/to-review >> After they are reviewed and if everyone is ok with the quality, i'd like to >> request svn access so I can push the commits myself onto the svn server (I >> wouldn't like seeing my patches committed under someone else's name to be >> honest). Boris (billiob) can vouch for me, and I do understand the >> responsabilities of having commit access (I've been project manager of aMSN >> for about 10 years now), and I promise I wouldn't mess with anything. My >> code is usually good quality and well tested before it gets pushed, and >> also, of course, until I get used to the E team's coding style and >> standards, I wouldn't commit anything that wouldn't have been previously >> reviewed and authorized by one of the long-term E developers. >> So please consider my request, if you'd like to see more patches from me >> before giving me svn access, then I suppose it can wait since none of the >> patches I sent are critical, but I'm ready to accept it if you'd like to >> push the commits now under someone else's authorship. > > Usually, when we commit patches sent by somebody that don't have svn > write access, > we make it clear on commit messages and include the name of the > developer to AUTHORS file, if the contribution > is relevant. > > So we don't stole authorship, ok ?
There's even a script for this, svn-git-am.py, that ensures the credit is given to whom it's due. Lucas De Marchi ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
