Ok, it's done, I've just pushed r63305 which makes it use sdl-config if it can't find sdl using pkg-config.
On Thu, Sep 8, 2011 at 4:07 AM, <cpmicha...@comcast.net> wrote: > > > ----- Original Message ----- > From: "Cedric BAIL" <cedric.b...@free.fr> > To: "Enlightenment developer list" < > enlightenment-devel@lists.sourceforge.net> > Sent: Wednesday, September 7, 2011 6:53:59 PM > Subject: Re: [E-devel] E SVN: kakaroto trunk/ecore > > On Wed, Sep 7, 2011 at 11:18 PM, Youness Alaoui > <kakar...@kakaroto.homelinux.net> wrote: > > You're right, I thought it was native code, not a script, so I didn't > think > > it could run on host machine. But I have sdl 1.2 locally, and it does > come > > with a pkgconfig file. If there are older versions that don't, then let > me > > know, I can revert it. > > Last time I give it a look, some distribution did the nice work of > adding the .pc and the latest SDL 1.2 is comming also with a .pc, it's > just previous that don't. And as the code doesn't require much to > support almost all SDL 1.2 version, I mould prefer a fallback to the > sdl-config code rather than a revert to previous method. So just if > .pc isn't found we fallback on sdl-config. That would be great. > > +1 > > dh > > > On Wed, Sep 7, 2011 at 3:55 AM, Cedric BAIL <cedric.b...@free.fr> wrote: > > > >> On Wed, Sep 7, 2011 at 8:53 AM, Enlightenment SVN > >> <no-re...@enlightenment.org> wrote: > >> > Log: > >> > Ecore: Use pkg-config to check for SDL, not sdl-config (which fails > for > >> cross-compilations) > >> > >> sdl-config is a shell script that just does some echo things. It work > >> just fine with cross-compilation as long as you specify it at > >> configure time. The issue is that older, read sdl 1.2, version don't > >> come with a pkg-config file. So it would be better if both method > >> where available. > >> > >> > Author: kakaroto > >> > Date: 2011-09-06 23:53:42 -0700 (Tue, 06 Sep 2011) > >> > New Revision: 63249 > >> > Trac: http://trac.enlightenment.org/e/changeset/63249 > >> > > >> > Modified: > >> > trunk/ecore/configure.ac > >> > > >> > Modified: trunk/ecore/configure.ac > >> > =================================================================== > >> > --- trunk/ecore/configure.ac 2011-09-07 06:53:35 UTC (rev 63248) > >> > +++ trunk/ecore/configure.ac 2011-09-07 06:53:42 UTC (rev 63249) > >> > @@ -523,26 +523,8 @@ > >> > # SDL library (ecore_sdl) > >> > > >> > have_sdl="no" > >> > -SDL_CONFIG="sdl-config" > >> > -AC_ARG_WITH([sdl-config], > >> > - [AC_HELP_STRING([--with-sdl-config=PATH], [use sdl-config > >> specified])], > >> > - [ > >> > - SDL_CONFIG=$withval > >> > - AC_MSG_NOTICE([using ${SDL_CONFIG} for sdl-config]) > >> > - ]) > >> > +PKG_CHECK_MODULES([SDL], [sdl >= 1.2.0], [have_sdl="yes"], > >> [have_sdl="no"]) > >> > > >> > -AC_PATH_PROG([SDL_CONFIG], ["sdl-config"], [""], [$PATH]) > >> > - > >> > -if test -n "$SDL_CONFIG" ; then > >> > - SDL_CFLAGS=`$SDL_CONFIG --cflags` > >> > - SDL_LIBS=`$SDL_CONFIG --libs` > >> > - AC_SUBST(SDL_CFLAGS) > >> > - AC_SUBST(SDL_LIBS) > >> > - have_sdl="yes" > >> > -else > >> > - PKG_CHECK_MODULES([SDL], [sdl >= 1.2.0], [have_sdl="yes"], > >> [have_sdl="no"]) > >> > -fi > >> > - > >> > if test "x${have_sdl}" = "xyes" ; then > >> > PKG_CHECK_EXISTS([sdl >= 1.3.0], > >> > [AC_DEFINE(BUILD_ECORE_EVAS_SDL_130, 1, [Support for SVN SDL])]) > >> > > >> > > >> > > >> > ------------------------------------------------------------------------------ > >> > Using storage to extend the benefits of virtualization and iSCSI > >> > Virtualization increases hardware utilization and delivers a new level > of > >> > agility. Learn what those decisions are and how to modernize your > storage > >> > and backup environments for virtualization. > >> > http://www.accelacomm.com/jaw/sfnl/114/51434361/ > >> > _______________________________________________ > >> > enlightenment-svn mailing list > >> > enlightenment-...@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > >> > > >> > > >> > >> > >> > >> -- > >> Cedric BAIL > >> > >> > >> > ------------------------------------------------------------------------------ > >> Using storage to extend the benefits of virtualization and iSCSI > >> Virtualization increases hardware utilization and delivers a new level > of > >> agility. Learn what those decisions are and how to modernize your > storage > >> and backup environments for virtualization. > >> http://www.accelacomm.com/jaw/sfnl/114/51434361/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > ------------------------------------------------------------------------------ > > Using storage to extend the benefits of virtualization and iSCSI > > Virtualization increases hardware utilization and delivers a new level of > > agility. Learn what those decisions are and how to modernize your storage > > and backup environments for virtualization. > > http://www.accelacomm.com/jaw/sfnl/114/51434361/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Using storage to extend the benefits of virtualization and iSCSI > Virtualization increases hardware utilization and delivers a new level of > agility. Learn what those decisions are and how to modernize your storage > and backup environments for virtualization. > http://www.accelacomm.com/jaw/sfnl/114/51434361/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > Doing More with Less: The Next Generation Virtual Desktop > What are the key obstacles that have prevented many mid-market businesses > from deploying virtual desktops? How do next-generation virtual desktops > provide companies an easier-to-deploy, easier-to-manage and more affordable > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Why Cloud-Based Security and Archiving Make Sense Osterman Research conducted this study that outlines how and why cloud computing security and archiving is rapidly being adopted across the IT space for its ease of implementation, lower cost, and increased reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
