Exactly, I only removed them because the symbols were never defined. ecore-sdl was always using the ecore-input events, so it never declared those.
On Mon, Sep 12, 2011 at 2:43 AM, Carsten Haitzler <ras...@rasterman.com>wrote: > On Mon, 12 Sep 2011 07:41:18 +0200 (CEST) Vincent Torri < > vto...@univ-evry.fr> > said: > > > > > > > On Sun, 11 Sep 2011, Enlightenment SVN wrote: > > > > > Log: > > > Ecore-sdl: remove unused events and fix semicolon typo and docs > > > > this is an API break > > actually ecore_sdl was already broken - it had the extern ints defined but > never backed them with real symbols - so anyone using those event id's > would > have had their code fail to link as it'd have never found symbols. so it's > not > an api break. it was already broken :( > > > Vincent > > > > > > > > Author: kakaroto > > > Date: 2011-09-11 20:43:46 -0700 (Sun, 11 Sep 2011) > > > New Revision: 63338 > > > Trac: http://trac.enlightenment.org/e/changeset/63338 > > > > > > Modified: > > > trunk/ecore/src/lib/ecore_sdl/Ecore_Sdl.h > > > trunk/ecore/src/lib/ecore_sdl/ecore_sdl.c > > > > > > Modified: trunk/ecore/src/lib/ecore_sdl/Ecore_Sdl.h > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_sdl/Ecore_Sdl.h 2011-09-12 03:43:37 > > > UTC (rev 63337) +++ trunk/ecore/src/lib/ecore_sdl/Ecore_Sdl.h > > > 2011-09-12 03:43:46 UTC (rev 63338) @@ -36,14 +36,8 @@ > > > extern "C" { > > > #endif > > > > > > -EAPI extern int ECORE_SDL_EVENT_KEY_DOWN; /**< SDL Key Down event */ > > > -EAPI extern int ECORE_SDL_EVENT_KEY_UP; /**< SDL Key Up event */ > > > -EAPI extern int ECORE_SDL_EVENT_MOUSE_BUTTON_DOWN; /**< SDL Mouse Down > > > event */ -EAPI extern int ECORE_SDL_EVENT_MOUSE_BUTTON_UP; /**< SDL > Mouse > > > Up event */ -EAPI extern int ECORE_SDL_EVENT_MOUSE_MOVE; /**< SDL Mouse > > > Move event */ -EAPI extern int ECORE_SDL_EVENT_MOUSE_WHEEL; /**< SDL > Mouse > > > Wheel event */ -EAPI extern int ECORE_SDL_EVENT_GOT_FOCUS; /**< SDL > Mouse > > > Wheel event */ -EAPI extern int ECORE_SDL_EVENT_LOST_FOCUS; /**< SDL > Mouse > > > Wheel event */ +EAPI extern int ECORE_SDL_EVENT_GOT_FOCUS; > > > +EAPI extern int ECORE_SDL_EVENT_LOST_FOCUS; > > > EAPI extern int ECORE_SDL_EVENT_RESIZE; > > > EAPI extern int ECORE_SDL_EVENT_EXPOSE; > > > > > > > > > Modified: trunk/ecore/src/lib/ecore_sdl/ecore_sdl.c > > > =================================================================== > > > --- trunk/ecore/src/lib/ecore_sdl/ecore_sdl.c 2011-09-12 03:43:37 > > > UTC (rev 63337) +++ trunk/ecore/src/lib/ecore_sdl/ecore_sdl.c > > > 2011-09-12 03:43:46 UTC (rev 63338) @@ -50,9 +50,9 @@ > > > } > > > > > > /** > > > - * @defgroup Ecore_Sdl_Library_Group Framebuffer Library Functions > > > + * @defgroup Ecore_Sdl_Library_Group SDL Library Functions > > > * > > > - * Functions used to set up and shut down the Ecore_Framebuffer > functions. > > > + * Functions used to set up and shut down the Ecore_Sdl functions. > > > */ > > > > > > /** > > > @@ -96,8 +96,8 @@ > > > EAPI int > > > ecore_sdl_shutdown(void) > > > { > > > - if (--_ecore_sdl_init_count != 0); > > > - return _ecore_sdl_init_count; > > > + if (--_ecore_sdl_init_count != 0) > > > + return _ecore_sdl_init_count; > > > > > > ecore_event_shutdown(); > > > eina_log_domain_unregister(_ecore_sdl_log_dom); > > > > > > > > > > ------------------------------------------------------------------------------ > > > Doing More with Less: The Next Generation Virtual Desktop > > > What are the key obstacles that have prevented many mid-market > businesses > > > from deploying virtual desktops? How do next-generation virtual > desktops > > > provide companies an easier-to-deploy, easier-to-manage and more > affordable > > > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > > > _______________________________________________ > > > enlightenment-svn mailing list > > > enlightenment-...@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > > > > > > ------------------------------------------------------------------------------ > > Doing More with Less: The Next Generation Virtual Desktop > > What are the key obstacles that have prevented many mid-market businesses > > from deploying virtual desktops? How do next-generation virtual > desktops > > provide companies an easier-to-deploy, easier-to-manage and more > affordable > > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > Doing More with Less: The Next Generation Virtual Desktop > What are the key obstacles that have prevented many mid-market businesses > from deploying virtual desktops? How do next-generation virtual desktops > provide companies an easier-to-deploy, easier-to-manage and more affordable > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Doing More with Less: The Next Generation Virtual Desktop What are the key obstacles that have prevented many mid-market businesses from deploying virtual desktops? How do next-generation virtual desktops provide companies an easier-to-deploy, easier-to-manage and more affordable virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
