2011/9/23 Jaehwan Kim <jae.hwan....@samsung.com>:
> Dear all,
>
> I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)"
> This work was requested by Daniel Juyung Seo.
> This API sets the state of all parts to default.
> Please check attached patch file.

The patch is simple to understand, so far so good. First remark, you
should better call _edje_recalc(ed); instead of edje_object_calc_force
as their is no need yet to recalculate everything it can wait.

The second and most concerning issue to me, is that you are changing
part state without resetting the embryo or lua vm and other internal
program. I think it is necessary, because you don't know what is
currently running inside it. So I would prefer this patch to implement
just a edje_object_reset(Evas_Object obj) that will also reset the
various vm, destroy all pending timer, destroy the content of the
event queue and stop all pending program. With that function we could
easily reuse the Edje object from a cache without the need to add a
special state that would reset it to default.
-- 
Cedric BAIL

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to