On Thu, 20 Oct 2011 09:53:00 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> wrote:
> Hello, > Talking about fixing indentation and removing wrong whitespaces, I've > been learned to do that from this mailing list when I started > uploading patches. I got reviewed and was requested to fix indentation > and remove trailing whitespaces. Of course, that's normal because to > new code has to be clean. > Anyhow, that's what I learned from here. So this became so normal to > me and others like hermet. I feel like it's my habit and if I see ugly > formatted code, I'd really love to fix them. > In my case when I work on a code, I fix indentation and whitespaces > first then apply my patch. I fix formatting before working on things too. A lot of the formatting in e is really bad due to tabs and such. > > But it looks like nowadays e-devs don't care about them anymore. > Especially raster :) > If so, I would not fix them and just add my code to trunk. > > I still think if we do not follow the convention, we can't force > others to follow that. > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > On Wed, Oct 19, 2011 at 9:13 PM, Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> wrote: > > Eheheheh... LMAO when i ser these commits in efl. > > > > There are huge number of whitespaces in EFL and nobody agrees fully, yet you > > replace every single finding... It keep getting introduced and loop! > > > > At least should provide good commit count for ya guys ;-) > > > > On Wednesday, October 19, 2011, Enlightenment SVN < > > no-re...@enlightenment.org> wrote: > >> Log: > >> eina/stringshare - get rid of white space > >> > >> > >> > >> Author: hermet > >> Date: 2011-10-19 01:36:42 -0700 (Wed, 19 Oct 2011) > >> New Revision: 64165 > >> Trac: http://trac.enlightenment.org/e/changeset/64165 > >> > >> Modified: > >> trunk/eina/src/lib/eina_stringshare.c > >> > >> Modified: trunk/eina/src/lib/eina_stringshare.c > >> =================================================================== > >> --- trunk/eina/src/lib/eina_stringshare.c 2011-10-19 07:54:31 UTC > > (rev 64164) > >> +++ trunk/eina/src/lib/eina_stringshare.c 2011-10-19 08:36:42 UTC > > (rev 64165) > >> @@ -542,7 +542,7 @@ > >> return; > >> > >> /* special cases */ > >> - if (str[0] == '\0') > >> + if (str[0] == '\0') > >> slen = 0; > >> else if (str[1] == '\0') > >> slen = 1; > >> > >> > >> > > ------------------------------------------------------------------------------ > >> All the data continuously generated in your IT infrastructure contains a > >> definitive record of customers, application performance, security > >> threats, fraudulent activity and more. Splunk takes this data and makes > >> sense of it. Business sense. IT sense. Common sense. > >> http://p.sf.net/sfu/splunk-d2d-oct > >> _______________________________________________ > >> enlightenment-svn mailing list > >> enlightenment-...@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > >> > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: barbi...@gmail.com > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > > All the data continuously generated in your IT infrastructure contains a > > definitive record of customers, application performance, security > > threats, fraudulent activity and more. Splunk takes this data and makes > > sense of it. Business sense. IT sense. Common sense. > > http://p.sf.net/sfu/splunk-d2d-oct > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Ciosco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Ciosco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
