On 23/10/11 10:24, Mike Blumenkrantz wrote: > On Sun, 23 Oct 2011 10:22:02 +0200 > Tom Hacohen<tom.haco...@partner.samsung.com> wrote: >> Trailing whites are bad for a couple reasons, some of which are: >> * unwanted increase in source code size (it's actually noticeable, but >> hey, it's also the case with spaces vs tabs). > yeah, and unnecessary prefixing of commit messages does the same. problem?
It's not unnecessary, I explained exactly why in the email I suggested it at, and I guess that's why people agreed with it. More than that, I think, and I believe that others agree, that this was a very needed and useful change, it surely made my life easier/more convenient. Furthermore, commits messages are different than source codes, making such comparison is at best a poor trolling attempt. >> * Increased likelihood of merge clashes. It's easier to miss whitespace >> changes when you don't care about them, and a lot of whites can make it >> nuts. > don't you use git which can avoid whitespace clashes? I do, but I'm not aware of any way to make git avoid whitespace clashes, but even if there is a way, there are still svn users out there. Please, if you know such a way, let me know, sounds like a useful trick. >> * Causing annoying line-wraps for no reason. (a couple of trailing whites). > use a real editor/term which doesn't have mandatory 80 character wrapping > since > we aren't in the 1960s anymore? It's part of the coding conventions, I can change it to whatever value I want in vim, but it's set as 80 cause that's what we all decided to follow (e coding conventions). Furthermore, I rather like 80, it's very useful, it lets you open a couple of instances of vim in the same window without any horizontal scrolling (or wrapping in my case). >> * People (I'm among them) just don't like trailing whites. > oh good, finally a real point. ;P >> * Some other things I can't think about atm. > stop claiming there's any reason to this besides not liking trailing > whitespaces. I don't like them, so I remove them. sometimes. to suggest > anything different is really not going to do anything but give me (and > others) some laughs. > As you can see, I stated a couple of reasons, one of which is the reason you mentioned, which holds on it's own, the others, are valid as well. I'm also against the whitespace witch-hunt, i.e going through all of svn and manually changing whitespace errors, but I'm very much against adding new errors to the code base. -- Tom. ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
