Hi, On Wed, Oct 26, 2011 at 10:55 AM, Vincent Torri <vto...@univ-evry.fr> wrote: > Eina includes eina_inline_lock_posix.h on something else than Windows, > hence pthread.h. _GNU_SOURCE is not defined. > > Suppose now that a user of Eina does this: > > #include <Eina.h> > #include <pthread.h> > > The user will not have the possibility to features available with > _GNU_SOURCE (like CPU_SET for example. I have that problem with Enesim), > except by defining it just before including Eina.h. Which is not the best > solution, I think. > > The problem, here, is that lock stuff is only inlined functions. The > problem will be solved if they are in a source file. Maybe at the > beginning, having these functions inlined was interesting because they > were short. I'm not sure that keeping them inlined is really useful, now.
As from a performance point of view, it really matter to have them inlined or not. Function call does cost. > Another solution would be to define _GNU_SOURCE before including pthread.h > (maybe under some conditions). But is it a good solution too ? > > Honestly, I don't know what the best solution is. So if someone knows how > to properly fix that problem... I have always started to put libc header first if I need them directly and then include other library. This just solve this kind of issue. So I don't thing it's an issue to solve. -- Cedric BAIL ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
