On Fri, 28 Oct 2011 17:18:46 +0900
Jaehwan Kim <jaehwan.kim....@gmail.com> wrote:

> +1 here also, if only so we get edje group inherit docs :P
> >
> 
> I changed some documents about group inheritance.
> Please review. is it enough? or must I do something more?
> 
> Index: src/bin/edje_cc_handlers.c
> ===================================================================
> --- src/bin/edje_cc_handlers.c (revision 64481)
> +++ src/bin/edje_cc_handlers.c (work copy)
> @@ -1970,8 +1970,12 @@
>      @parameters
>          [parent group name]
>      @effect
> -        Parent group name for inheritance. The parent group have to defined
> -        in advance.
> +        Parent group name for inheritance.
> +        Group "inhreit" is used to inherit any predefined group and change
                  inherit
> +        some property which belong to "part", "description", "items" and
                               belongs                                  or
> "program".
> +        The child group has the same property as parent group. The
> properties
> +        can be changed according the name of "part", "description", "items"
> and
this line is confusing, saying less would actually be more helpful
> +        "program". But the type of the part cannot be changed.
also worth stating is that if you specify the type again in an inherited part,
it will cause an error (unless you plan to fix that)
>      @endproperty
>      @since 1.1.0
>  */
> @@ -4562,7 +4566,7 @@
>          [another part's name]
>      @effect
>          Causes a corner to be positioned relatively to another part's
> -        container.
> +        container. "" means to be positioned relatively to own group.
mm this is wrong and confusing. something more like
[[
Setting to "" will un-set this value for inherited parts.
]]
since you would only ever use it with group inheritance
>      @endproperty
>  */
>  static void
> @@ -4593,6 +4597,7 @@
>      @effect
>          Causes a corner to be positioned relatively to the X axis of
> another
>          part's container. Simply put affects the first parameter of
> "relative".
> +        "" means to be positioned relatively to the X axis of own group.
same as above
>      @endproperty
>  */
>  static void
> @@ -4622,7 +4627,8 @@
>      @effect
>          Causes a corner to be positioned relatively to the Y axis of
> another
>          part's container. Simply put, affects the second parameter of
> -        "relative".
> +        "relative". "" means to be positioned relatively to the Y axis
> +        own group.
same as above
>      @endproperty
>  */
>  static void
definitely an improvement. A for effort.

-- 
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to