I'll just leave this here for raster to get to when he has time, since
he wrote this bit.

static int
_elua_objgeom(lua_State *L)
{
   Edje *ed = (Edje *)_elua_table_ptr_get(L, _elua_key);
   if (!lua_istable(L, 1)) lua_newtable(L);
   _elua_ret(L, "%x %y %w %h", ed->x, ed->y, ed->w, ed->h);
}

That lua_istable() test in the middle worries me.  This function has no
arguments, the call before it leaves the stack at the same level
(that is, empty).  So there's nothing on the stack to check if it's a
table.  I'm not sure what you where thinking, perhaps that the user
could pass in a table to be filled in?  Seems odd.

There's a few of these, I'll just leave a FIXME comment for now, but
I'll probably remove the check before the release.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to