Sorry Tom.
But I already reviewed it then pushed.
rev - 65680.
------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "Tom Hacohen"<[email protected]>
To: "Enlightenment developer
list"<[email protected]>
Cc: "PRINCE KUMAR DUBEY"<[email protected]>
Sent: 11-11-29(화) 17:17:03
Subject: Re: [E-devel] [Patch] elm_gesture_layer patch
On 29/11/11 07:48, PRINCE KUMAR DUBEY wrote:
> Hi,
>
> On behalf of Rajeev Ranjan, I am submitting the elm_gesture_layer patch.
>
> Change Log:
> a. Variable was used after freeing in function _remove_touched_device, now
> storing return value of eina_list_remove and then freeing pointer.
> b. gesture pointer was dereferenced before checking it against NULL in
> function _rotate_test. Now dereferencing happens after NULL check.
> c. Added NULL check for pointer before using it in function _event_process
> which is dereferenced in function _add_touched_device.
> d. Memory leak fix in function elm_gesture_layer_add. Now using
> ELM_WIDGET_STANDARD_SETUP which takes care of NULL checks and freeing memory
> in case of failure.
>
> Please review it.
> I'd appreciate any comments on this.
Thank you very much for the patch. I want Aharon (from my team) to
review it, but afterwards I'll get it in.
From what I've seen while skimming, the patch looks good!
Thanks,
Tom.
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
