On Fri, 2 Dec 2011 08:42:43 +0100 (CET) Vincent Torri <[email protected]> said:
> > > On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: > > > On Fri, 2 Dec 2011 08:28:36 +0100 (CET) Vincent Torri <[email protected]> > > said: > > > >> > >> > >> On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: > >> > >>> On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger > >>> <[email protected]> said: > >>> > >>> this is really late... and a lot of these patches i find questionable. > >>> i'll question here (things not questioned seem ok): > >>> > >>> 1. __SUNPRO_C instead of __sun <- explain why you dont just ADD an extra > >>> || defined(__SUNPRO_C) and why the check for __sun should be removed? > >> > >> __sun : it's a sun compiler > >> __SUNPRO_C : it's a sun compiler and that macro has the value of the > >> compiler version > > > > so... its exactly the same check - ALL sun compilers that have __sun set > > ALSO set __SUNPRO_C ? > > http://developers.sun.com/sunstudio/products/faqs/cpp.html#q1 so.. the code can stay as-is then. no need to change. :) > Vincent > > > > >>> 2. all the chasting and changing to unsigned char for passing into isspace > >>> () - isspace() actually takes an int, not unsigned char, so this just > >>> doesn't make sense. :( (well it does according to the manual page i have) > >> > >> same here, it takes an int. As isspace() is conforming to C89, i doubt it > >> takes something else than an int. > > > > agreed. this looks "bogus" > > > >> Vincent > >> > >>>> Hi all, > >>>> sorry for not finding the time for doing this earlier. Attached is a > >>>> patch that sorts out a number of smaller issues with eina on NetBSD and > >>>> Solaris. Some are noise, some are real bugs. This brings it down to one > >>>> compiler warning for iconv, which is expected (and messy). > >>>> > >>>> Joerg > >>> > >>> > >>> -- > >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- > >>> The Rasterman (Carsten Haitzler) [email protected] > >>> > >>> > >>> ------------------------------------------------------------------------------ > >>> All the data continuously generated in your IT infrastructure > >>> contains a definitive record of customers, application performance, > >>> security threats, fraudulent activity, and more. Splunk takes this > >>> data and makes sense of it. IT sense. And common sense. > >>> http://p.sf.net/sfu/splunk-novd2d > >>> _______________________________________________ > >>> enlightenment-devel mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>> > >>> > >> > >> ------------------------------------------------------------------------------ > >> All the data continuously generated in your IT infrastructure > >> contains a definitive record of customers, application performance, > >> security threats, fraudulent activity, and more. Splunk takes this > >> data and makes sense of it. IT sense. And common sense. > >> http://p.sf.net/sfu/splunk-novd2d > >> _______________________________________________ > >> enlightenment-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
