On Fri, 2 Dec 2011 09:53:37 -0800 "Enlightenment SVN" <no-re...@enlightenment.org> wrote:
> Log: > eet: revert works from discomfitor. too buggy elementary segv. I'm pleased to > SPANK him :D > > Author: yoz > Date: 2011-12-02 09:53:37 -0800 (Fri, 02 Dec 2011) > New Revision: 65828 > Trac: http://trac.enlightenment.org/e/changeset/65828 > > Modified: > trunk/eet/ChangeLog trunk/eet/NEWS trunk/eet/src/lib/Eet_private.h > trunk/eet/src/lib/Makefile.am trunk/eet/src/lib/eet_dictionary.c > trunk/eet/src/lib/eet_lib.c > REVERSE SPANK SPANK SPANK. COMPOUND INTEREST SPANK SPANK SPANK SPANK SPANK SPANK! Question: When was the last time a commit was reverted for causing breakage? Hint: despite breaking all apps during a code freeze, it was not @65619 Hint #2: even though it broke compile for several days, it was not @65642 Answer: @64928 was reverted because it was caused breakage AND was wrong. If you see something broken in trunk you have a number of options: 1) fix it yourself -> THIS is when spankies should be administered 2) tell the committer to fix it 3) use an older commit until it gets fixed Reverting commits is NOT the answer, and reverting only parts of them is even worse. ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
