On Wed, Dec 7, 2011 at 8:26 AM, Vincent Torri <vincent.to...@gmail.com>wrote:
> > > On Wed, Dec 7, 2011 at 8:21 AM, Vincent Torri <vincent.to...@gmail.com>wrote: > >> >> >> On Wed, Dec 7, 2011 at 4:52 AM, Myungjae Lee <sac...@gmail.com> wrote: >> >>> Dear, Tom, Raster and EFL people. >>> >>> Please review this patch and apply it if it's acceptable. >>> Or if you have any opinion for this feel free to give me a feedback. >>> >> >> i've not tested it, but : >> >> 1) all the functions must have a namespace : missing '_edje' before >> '_is_separator' >> > > it's just an example, there are other static functions without '_edje' (or > _edje_entry would actually be better) > > > and while i'm reading it again, i see that > > a) static void _edje_entry_mouse_double_clicked should be formatted like > that: > > static void > _edje_entry_mouse_double_clicked(***) > > b) some functions are not static and they are not used elsewhere, it > seems. In that case, they should be declared and defined as static. > and finally : c) "int len;" should be "size_t len;" > > >> 2) update ChangeLog >> 3) Update NEWS >> 4) missing @since 1.1 in the documentation of the API >> >> Vincent >> > > ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
