Hi,
There is invalid return value checking of curl_multi_perform() in ecore_con_url.
Because CURLM_CALL_MULTI_PERFORM is also not CURLM_OK,
CURLM_CALL_MULTI_PERFORM checking should precede CURLM_OK checking.
It's simple fix. Please review this
--
BRs,
Kim.
Index: src/lib/ecore_con/ecore_con_url.c
===================================================================
--- src/lib/ecore_con/ecore_con_url.c (리비전 66761)
+++ src/lib/ecore_con/ecore_con_url.c (작업 사본)
@@ -1555,16 +1555,16 @@ _ecore_con_url_idler_handler(void *data
CURLMcode ret;
ret = curl_multi_perform(_curlm, &still_running);
- if (ret != CURLM_OK)
+ if (ret == CURLM_CALL_MULTI_PERFORM)
{
- ERR("curl_multi_perform() failed: %s", curl_multi_strerror(ret));
- _ecore_con_url_curl_clear();
- ecore_timer_freeze(_curl_timeout);
+ DBG("Call multiperform again");
return ECORE_CALLBACK_RENEW;
}
- if (ret == CURLM_CALL_MULTI_PERFORM)
+ else if (ret != CURLM_OK)
{
- DBG("Call multiperform again");
+ ERR("curl_multi_perform() failed: %s", curl_multi_strerror(ret));
+ _ecore_con_url_curl_clear();
+ ecore_timer_freeze(_curl_timeout);
return ECORE_CALLBACK_RENEW;
}
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
