On Sat, Jan 7, 2012 at 7:21 PM, Michael Blumenkrantz <michael.blumenkra...@gmail.com> wrote: > On Sat, 7 Jan 2012 18:16:04 +0000 > Iván Briano (Sachiel) <sachi...@gmail.com> wrote: > >> 2012/1/7 Gustavo Sverzut Barbieri <barbi...@profusion.mobi>: >> > On Sat, Jan 7, 2012 at 9:39 AM, Enlightenment SVN >> > <no-re...@enlightenment.org> wrote: >> >> Log: >> >> Edje: hide an object after unswallow >> >> Simply doing an unswallow would leave the object where it was in the >> >> evas, visible, but edje would not be handling it anymore. >> > >> > nah, you're supposed to do this in the application or edje user. Very >> > likely you'll delete the object, sometimes hide it. >> > >> > If you hide by default, novice will not see the object and will >> > leak... it's like a warning. >> > >> >> And if for some reason the change stays in, it's one of those >> very special things that deserve big bold letters in Changelog >> and NEWS files. >> > I'm pretty sure it's wrong to implement things that completely change expected > behavior like this in a non-major version...
It's not changing any expected behaviour. When edje unswallow an object, you are not supposed to expect it in any particular state. Now you can expect it to be hidden. That's just what it does. It defines the output state, something that wasn't before. The point that make sense is the one that Gustavo raise. With previous behaviour, in some case you will notice that an object was not handle by edje anymore, because it was visibly lying around. I may be wrong, but if the part was not visible, unswallow would have issued an hidden object, like this patch does. So I don't know now, if the best is to force its visibility or to hide. -- Cedric BAIL ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
