looks good to me.
in. 66985.
thank you.
------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "Kim Shinwoo"<kimcinoo....@gmail.com>
To: "Enlightenment developer
list"<enlightenment-devel@lists.sourceforge.net>
Cc:
Sent: 12-01-09(월) 15:12:04
Subject: Re: [E-devel] [Patch] elc_ctxpopup, using
elm_smart_scroller_freeze_set() not elm_object_scroll_freeze_push(), pop()
Hey.. :)
This is more proper way for resoling the issue which is caused by calling
elm_object_scroll_freeze_pop() two times in a
row. If user calls elm_object_scroll_freeze_pop() two times in a row, then
the evas_object_smart_callback_call(obj, "scroll-freeze-off", obj); is
called two times. Even though evas_object_smart_callback_call(obj,
"scroll-freeze-on", obj); is called just one time.
If there is no specific intention(purpose), it is better to keep the
consistency.
Moreover, Sometimes, It will cause the infinite loop as in some case of
using the ctxpopup.
Please review the attached patch. Thank you.
2011년 12월 28일 오후 1:18, ChunEon Park <her...@naver.com>님의 말:
> Understood the problem.
> It's more acceptable to freeze the scroller only.
> in. rev 66584
> Thank you.
> ------------------------------------
> -Regards, Hermet-
>
> -----Original Message-----
> From: "cnook"<kimci...@gmail.com>
> To: "EFL"<enlightenment-devel@lists.sourceforge.net>
> Cc:
> Sent: 11-12-27(화) 22:02:11
> Subject: [E-devel] [Patch] elc_ctxpopup, using
> elm_smart_scroller_freeze_set() not elm_object_scroll_freeze_push(), pop()
> Dear All, Hello~
> The ctxpopup had used elm_ojbect_scroll_freeze_push(), pop() for the
> scroll-freeze-on,of callback.
> If user calls elm_object_scroll_freeze_pop() only after
> elm_ojbect_scroll_freeze_push(), then it will be fine.
> But sometimes user calls elm_object_scroll_freeze_pop() two times in a
> row.. Then you can find there is infinite loop in following..
> EAPI void
> elm_widget_scroll_freeze_pop(Evas_Object *obj)
> {
> API_ENTRY return;
> sd->scroll_freeze--;
> if (sd->scroll_freeze < 0) sd->scroll_freeze = 0;
> if (!sd->scroll_freeze)
> evas_object_smart_callback_call(obj, "scroll-freeze-off", obj);
> if (sd->parent_obj) elm_widget_scroll_freeze_pop(sd->parent_obj);
> }
> ctxpopup calls elm_widget_scroll_freeze_pop(wd->scr);finally. wd->scr
> is widget data of ctxpopup.
> Now the the sd->parent_obj is ctxpopup, next time
> evas_object_smart_callback_call(obj, "scroll-freeze-off", obj); is
> called again by using ctxpopup as obj.
> Anyhow, other widgets..
> the ctxpopup should use elm_smart_scroller_freeze_set() with an attached
> patch.
> Sincerely,
> Shinwoo Kim.
>
> ------------------------------------------------------------------------------
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
>
> http://p.sf.net/sfu/intel-appdev_______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> ------------------------------------------------------------------------------
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free!
http://p.sf.net/sfu/Citrix-VDIinabox_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
