Hello.
On Sun, 2012-01-15 at 13:24, Stefan Schmidt wrote:
>
> > 2) separate patch contents by component (eg. the two patches in this mail
> > should have actually been two separate patches since they will require two
> > people to review)
>
> Agreed here. That was just lazyness. Will re-send them.
Please find both patches attached.
regards
Stefan Schmidt
>From 12bb9360e58463cdac581caaa9a7b720d2e10b70 Mon Sep 17 00:00:00 2001
From: Stefan Schmidt <ste...@datenfreihafen.org>
Date: Sun, 15 Jan 2012 13:42:54 +0100
Subject: [PATCH 1/2] ecore_x_randr_11: Remove unused sizes variable
Signed-off-by: Stefan Schmidt <ste...@datenfreihafen.org>
---
ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c b/ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c
index 2fd50a6..4e5f895 100644
--- a/ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c
+++ b/ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c
@@ -211,16 +211,11 @@ ecore_x_randr_screen_primary_output_size_set(Ecore_X_Window root,
{
#ifdef ECORE_XRANDR
XRRScreenConfiguration *sc = NULL;
- XRRScreenSize *sizes;
Eina_Bool ret = EINA_FALSE;
int nsizes = 0;
if (size_index >= 0 && _ecore_x_randr_root_validate(root))
{
- sizes =
- XRRSizes(_ecore_x_disp, XRRRootToScreen(_ecore_x_disp,
- root), &nsizes);
-
if (size_index < nsizes)
{
sc = XRRGetScreenInfo(_ecore_x_disp, root);
--
1.7.8.3
>From e825ba31cf0f2c3358d984c6e555c8bde9da3257 Mon Sep 17 00:00:00 2001
From: Stefan Schmidt <ste...@datenfreihafen.org>
Date: Sun, 15 Jan 2012 13:46:07 +0100
Subject: [PATCH 2/2] ecore_con_info: Remove unused err variable.
Signed-off-by: Stefan Schmidt <ste...@datenfreihafen.org>
---
ecore/src/lib/ecore_con/ecore_con_info.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/ecore/src/lib/ecore_con/ecore_con_info.c b/ecore/src/lib/ecore_con/ecore_con_info.c
index f451f6a..b0d113d 100644
--- a/ecore/src/lib/ecore_con/ecore_con_info.c
+++ b/ecore/src/lib/ecore_con/ecore_con_info.c
@@ -244,7 +244,6 @@ ecore_con_info_get(Ecore_Con_Server *svr,
unsigned char *tosend = NULL;
int tosend_len;
int canonname_len = 0;
- int err;
eina_convert_itoa(svr->ecs ? svr->ecs->port : svr->port, service);
/* CHILD */
@@ -281,13 +280,13 @@ ecore_con_info_get(Ecore_Con_Server *svr,
memcpy(container->service, sbuf, sizeof(container->service));
}
- err = write(fd[1], tosend, tosend_len);
+ write(fd[1], tosend, tosend_len);
}
if (result)
freeaddrinfo(result);
- err = write(fd[1], "", 1);
+ write(fd[1], "", 1);
close(fd[1]);
#if defined(__USE_ISOC99) && !defined(__UCLIBC__)
_Exit(0);
--
1.7.8.3
------------------------------------------------------------------------------
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
