On Wed, 18 Jan 2012 13:21:50 +0900 Jihoon Kim <imfin...@gmail.com> said:
your e_entry patch is broken, but thats ok. i used previous one. i really just needed ecore patch fixed :) > Since I sent patch, there are some code changes in ecore_imf_xim.c and > edje_entry.c. > > Patch files are written based on the latest EFL code and I send again. > > Would you please review again? :) > > On Wednesday, January 18, 2012, Carsten Haitzler wrote: > > > On Tue, 10 Jan 2012 16:58:28 +0900 Jihoon Kim > > <imfin...@gmail.com<javascript:;>> said: > > > > i took a look at the patches - seem sane... BUT one problem.. > > > > $ patch -p0 < ~/ecore_imf_sync.patch > > patching file src/lib/ecore_imf/ecore_imf_private.h > > patching file src/lib/ecore_imf/ecore_imf_context.c > > patching file src/lib/ecore_imf/Ecore_IMF.h > > patching file src/modules/immodules/scim/scim_imcontext.cpp > > patching file src/modules/immodules/xim/ecore_imf_xim.c > > Hunk #1 succeeded at 389 with fuzz 1 (offset 26 lines). > > Hunk #2 FAILED at 372. > > Hunk #3 succeeded at 708 with fuzz 1 (offset 39 lines). > > Hunk #4 FAILED at 832. > > Hunk #5 FAILED at 853. > > Hunk #6 FAILED at 975. > > Hunk #7 FAILED at 996. > > Hunk #8 succeeded at 1212 (offset 50 lines). > > 5 out of 8 hunks FAILED -- saving rejects to file > > src/modules/immodules/xim/ecore_imf_xim.c.rej > > > > :( > > > > > Long time ago, in > > > > > http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg32795.html > > > mail thread and IRC, > > > > > > I talked with about problem of asynchronous event API such as > > > ecore_imf_context_commit_event_add, > > > ecore_imf_context_preedit_changed_event_add, so on. > > > > > > In short, The problem is that key event and text_set APIs are processed > > > immediately, but commit event and preedit changed event is processed > > > asynchronously > > > > > > because those APIs add each event to ecore event queue. > > > > > > > > > > > > To fix these problems, I've decided to create synchronous event APIs such > > > as ecore_imf_context_event_callback_add, del and call. > > > > > > > > > > > > For considering compatibility, sync and async event callback functions > > are > > > used in xim and scim immodule. > > > > > > > > > > > > Would you please review this patch? > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com <javascript:;> > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
