I guess this is the wrong fix.

The problem I was fixing (if I remember correctly) is that if you unload 
a module, the gadman will segv as the underlying code is gone.

S.

On 01/16/2012 10:54 PM, Enlightenment SVN wrote:
> Log:
> Revert a 13 months old commit by englebass
>
>    Messagge was:
>    module unload will delete gadcons, so we need to cleanup in gadman as
>    well.
>
>
>    This cause all my gadget to be deleted when I switch from 1 monitor
>    to 2 monitors (while e is running). This probably occcur also when
>    switching resolution.
>
>    Also I don't like all the gadgets configs to be deleted when the
>    gadman module is unloaded, we have a conservative approch with
>    gadget config, so don't see the reason to delete all my gadget
>    here.
>
>    DaveMDS
>
>
>
> Author:       davemds
> Date:         2012-01-16 13:54:53 -0800 (Mon, 16 Jan 2012)
> New Revision: 67251
> Trac:         http://trac.enlightenment.org/e/changeset/67251
>
> Modified:
>    trunk/e/src/modules/gadman/e_mod_gadman.c
>
> Modified: trunk/e/src/modules/gadman/e_mod_gadman.c
> ===================================================================
> --- trunk/e/src/modules/gadman/e_mod_gadman.c 2012-01-16 21:05:58 UTC (rev 
> 67250)
> +++ trunk/e/src/modules/gadman/e_mod_gadman.c 2012-01-16 21:54:53 UTC (rev 
> 67251)
> @@ -188,7 +188,6 @@
>      /* init Gadcon_Client */
>      gcc = cc->func.init(gc, cf->name, cf->id, cc->default_style);
>      if (!gcc) return NULL;
> -   e_object_del_func_set(E_OBJECT(gcc), 
> E_OBJECT_CLEANUP_FUNC(gadman_gadget_del));
>      gcc->cf = cf;
>      gcc->client_class = cc;
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> enlightenment-svn mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to