On 19/01/12 19:44, Gustavo Sverzut Barbieri wrote: > On Thu, Jan 19, 2012 at 3:12 PM, Tom Hacohen < > [email protected]> wrote: > >> Hey Gustavo and Stefan, >> >> That's a bad fix. The EFL_ALWAYS_INLINE macro is defined in the efl m4 >> file (don't remember the exact name). In it, it can be defined as either >> "__forceinline", "__attribute__ ((__always_inline__)) inline" or "static >> inline". In the last case your changes will break. The correct thing to do >> is to fix the macro, and also copy the macro around the other source trees >> of efl (how redundant is that?). I did the change locally but then I was >> too lazy to check all the potential code paths. >> >> Bottom line, your code won't compile in specific configurations and you >> have to revert your commit, fix the macro, and copy the macro all around >> efl. > > > while I understand the attributes changing per-platform, I have no idea why > it would change the "static". >
So remove it, doesn't matter, it still needs fixing. -- Tom. ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
