On Sun, 5 Feb 2012 16:15:55 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> wrote:
> Hello, I prefer elm_panes_handler_fixed_set(). This gives clear idea of > what it exactly does. > > I recommend: > > 1. fix elm_panes_fixed_set. > 2. add elm_panes_handler_fixed_set, add docs, and deprecate > elm_panes_fixed_set. > > my 2 cents. > On Feb 3, 2012 9:28 PM, "Rajeev Ranjan" <rajee...@samsung.com> wrote: > > > Hi Michael, > > > On 02/03/12 00:12, Christopher Michael wrote: > > > Ok, so how about elm_panes_position_fixed_set ? > > I agree with this new name. > > How about making the existing API elm_panes_fixed_set() work by applying > > the patch for default theme and then replace this API with > > elm_panes_poistion_fixed_set() by deprecating the existing one? > > I would need to update the documentation for these existing APIs as well > > as it is not there at present. > > Thank you. > > Regards, > > Rajeev > > > > ------- Original Message ------- > > Sender : Christopher Michael<cpmicha...@comcast.net> > > Date : Feb 03, 2012 20:55 (GMT+05:30) > > Title : Re: [E-devel] [Patch] elm_panes patch > > > > On 02/03/12 00:12, Rajeev Ranjan wrote: > > > Hi, > > >>>> On 02/02/12 10:41, Michael Blumenkrantz wrote: > > >>>> I'd like to see: > > >>>> > > >>>> >> This patch addresses the issue of API elm_panes_fixed_set > > >>>> > 'size_fixed_set' > > >>>> > > >>>> renamed to elm_panes_size_fixed_set OR elm_panes_fixed_size_set ... > > >>>> elm_panes_fixed_set doesn't exactly tell me what is being "fixed". > > >>>> > > > > > > imho, elm_panes_size_fixed_set() gives the impression that the overall > > panes size can't be changed however that is not the case as one can do so > > by putting panes in a widget which can change its overall size. > > > However this API just fixes the handler's poistion at the current > > relative position so that the contents' relative sizes don't change by > > dragging the handler. > > > > > Ok, so how about elm_panes_position_fixed_set ? > > > > dh > > > > >>> On Thu, 02 Feb 2012 10:38:20 -0500 > > >>> Christopher Michael wrote: > > >>> hmm imo elm_panes_locked_set() might be even better since this more > > effectively > > >>> describes the actual operation taking place > > > > > > Yeah, this looks better. We can consider something like > > elm_panes_handler_fixed_set() if people here don't agree with the API name > > elm_panes_locked_set(). > > > But now when this API(elm_panes_fixed_set) is already there in the > > elementary package, won't it be better to make this API working by applying > > this patch and then deprecate it and replace it with new one! > > > Regards, > > > Rajeev > > > > > > ------- Original Message ------- > > > Sender : Michael Blumenkrantz > > > Date : Feb 02, 2012 21:19 (GMT+05:30) > > > Title : Re: [E-devel] [Patch] elm_panes patch > > > > > > On Thu, 02 Feb 2012 10:46:33 -0500 > > > Christopher Michael wrote: > > > > > >> On 02/02/12 10:41, Michael Blumenkrantz wrote: > > >>> On Thu, 02 Feb 2012 10:38:20 -0500 > > >>> Christopher Michael wrote: > > >>> > > >>>> On 02/02/12 08:40, Rajeev Ranjan wrote: > > >>>>> Hi Michael, > > >>>>> Without this patch even if one sets the second parameter of API > > >>>>> elm_panes_fixed_set(Evas_Object obj, Eina_Bool fixed) to EINA_TRUE, > > there > > >>>>> is no impact and handler does not get fixed to the current location. > > The > > >>>>> internal edje signals emitted in this API is not handled in default > > >>>>> theme's edc, hence there is no effect. The parts and programs needed > > to > > >>>>> handle these edje signals for default theme are included in this > > patch. I > > >>>>> can raise a separate patch for updating the documentation of this > > API in > > >>>>> the header file src/lib/elm_panes.h once we get it working for > > default > > >>>>> theme. Regards, Rajeev > > >>>>> > > >>>>> P.S.: Resending the mail as the previous one's content was not sent > > to the > > >>>>> community. > > >>>>> > > >>>> > > >>>> I'd like to see: > > >>>> > > >>>> >> This patch addresses the issue of API elm_panes_fixed_set > > >>>> > 'size_fixed_set' > > >>>> > > >>>> renamed to elm_panes_size_fixed_set OR elm_panes_fixed_size_set ... > > >>>> elm_panes_fixed_set doesn't exactly tell me what is being "fixed". > > >>>> > > >>>> dh > > >>>> > > >>>>> > > >>>>> ------- Original Message ------- > > >>>>> Sender : Christopher Michael > > >>>>> Date : Feb 02, 2012 14:36 (GMT+05:30) > > >>>>> Title : Re: [E-devel] [Patch] elm_panes patch > > >>>>> > > >>>>> On 02/02/12 01:15, Rajeev Ranjan wrote: > > >>>>>> Hi, > > >>>>>> > > >>>>>> Attached to the mail is patch for Elementary Widget elm_panes. > > >>>>>> This patch addresses the issue of API elm_panes_fixed_set > > >>>>> 'size_fixed_set' > > >>>>> > > >>>>> dh > > >>>>> > > >>>>> not working as the signal required to do so is not handled in > > default > > >>>>> theme. > > >>>>> signals..sigs.. > > >>>>> > > >>>>>> > > >>>>>> Change Log: > > >>>>>> a. Implementation of API elm_panes_fixed_set for default theme. > > When this > > >>>>>> property is set to TRUE, then the handler gets invisible > > >>>>> > > >>>>> last i checked, invisible was invis.....not for the user..wm ovrd? > > input > > >>>>> only? > > >>>>> > > >>>>> and user can't change the relative size of the contents by dragging > > it. > > >>>>>> > > >>>>> no more comment right now. > > >>>>> > > >>>>> dh > > >>>>> > > >>>>>> Signed-Off-By: RAJEEV RANJAN > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> In the current API elm_panes_fixed_set, we don't disable the content > > >>>>>> regions, just divider is set to fixed at the current position. > > >>>>>> > > >>>>>> We are not implementing this using disable_hook as I could not find > > any > > >>>>>> disable_hook for similar containers like panel, box etc and > > moreover we > > >>>>>> won't be disabling the content regions in this case which will be > > >>>>>> different from the existing implementations for disable_hook in > > multiple > > >>>>>> widgets. > > >>>>>> > > >>>>>> > > >>>>>> Thank you > > >>>>>> Regards, > > >>>>>> Rajeev > > >>>>>> > > >>>> > > >>>> > > >>>> > > >>> hmm imo elm_panes_locked_set() might be even better since this more > > >>> effectively describes the actual operation taking place > > >>> > > >> > > >> Sure. That would work too. Point being, something a bit more descriptive > > >> about that operation which is being handled. > > >> > > >> dh > > >> > > > agree > > handler is wrong. a handler is something which handles another thing. a handle is something you grab to resize panes. ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
