Since a similar problem could be happened when user calls 
evas_object_pass_event_set.
Your patch may need to have a review still.
------------------------------------
-Regards, Hermet-
 
-----Original Message-----
From: "Hyoyoung Chang"<hyoyo...@gmail.com> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>
Cc: 
Sent: 12-02-12(일) 00:22:53
Subject: Re: [E-devel] E SVN: hermet trunk/evas/src/lib/canvas
yeah, it's one of waited improvement.
if then in evas callback call, mouse event checking isn't needed anymore?
2012/2/11 ChunEon Park <her...@naver.com>:
> ;)
> ------------------------------------
> -Regards, Hermet-
>
> -----Original Message-----
> From: "Christopher Michael"<cpmicha...@comcast.net>
> To: enlightenment-devel@lists.sourceforge.net
> Cc:
> Sent: 12-02-11(토) 00:28:38
> Subject: Re: [E-devel] E SVN: hermet trunk/evas/src/lib/canvas
> On 02/10/12 08:39, Enlightenment SVN wrote:
>> Log:
>> evas/evas_events - do not call the up event when obj is freezed and removed 
>> useless codes.
>>
> Good job Hermet !! ;) Make sure we are not calling down (or any other
> mouse events either) when things are frozen. Frozen should be just that
> ... frozen.
> dh
>>
>>
>> Author: hermet
>> Date: 2012-02-10 05:39:15 -0800 (Fri, 10 Feb 2012)
>> New Revision: 67828
>> Trac: http://trac.enlightenment.org/e/changeset/67828
>>
>> Modified:
>> trunk/evas/src/lib/canvas/evas_events.c
>>
>> Modified: trunk/evas/src/lib/canvas/evas_events.c
>> ===================================================================
>> --- trunk/evas/src/lib/canvas/evas_events.c 2012-02-10 13:32:50 UTC (rev 
>> 67827)
>> +++ trunk/evas/src/lib/canvas/evas_events.c 2012-02-10 13:39:15 UTC (rev 
>> 67828)
>> @@ -486,8 +486,9 @@
>> }
>> if (!obj->delete_me)
>> {
>> - if (e->events_frozen<= 0)
>> - evas_object_event_callback_call(obj, EVAS_CALLBACK_MOUSE_UP,&ev, event_id);
>> + if ((e->events_frozen<= 0)&&
>> + (!evas_event_freezes_through(obj)))
>> + evas_object_event_callback_call(obj, EVAS_CALLBACK_MOUSE_UP,&ev, event_id);
>> }
>> if (e->delete_me) break;
>> if (obj->pointer_mode == EVAS_OBJECT_POINTER_MODE_NOGRAB_NO_REPEAT_UPDOWN)
>> @@ -1668,18 +1669,6 @@
>> if (obj->freeze_events == freeze) return;
>> obj->freeze_events = freeze;
>> evas_object_smart_member_cache_invalidate(obj, EINA_FALSE, EINA_TRUE);
>> - if (evas_object_is_in_output_rect(obj,
>> - obj->layer->evas->pointer.x,
>> - obj->layer->evas->pointer.y, 1, 1)&&
>> - ((!obj->precise_is_inside) ||
>> - (evas_object_is_inside(obj,
>> - obj->layer->evas->pointer.x,
>> - obj->layer->evas->pointer.y))))
>> - evas_event_feed_mouse_move(obj->layer->evas,
>> - obj->layer->evas->pointer.x,
>> - obj->layer->evas->pointer.y,
>> - obj->layer->evas->last_timestamp,
>> - NULL);
>> }
>>
>> EAPI Eina_Bool
>>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to