On Fri, 10 Feb 2012 18:26:08 +0900 Hyoyoung Chang <hyoyo...@gmail.com> said:
1. your patch has your "minw ... wd->w" stuff (bugfix at genlist rotation) 2. refcount should start at 1 imho. 3. delete_me -> use bitfield (delete_me : 1) 4. i'd prefer the version field to be at the start, not end of class. i kn-w this breaks abi with current apps, but we have to do this to make things work into the future. also move refcount and delete_me flag to the start too. keep func at the end please :) fix these and then thumbs up :) > Dear all. > > I make controversial apis for item class management. > As raster and other guys suggest, I simplify APIs and its behaviors. > > First, Two public apis and two internal apis are introduced > > +EAPI Elm_Genlist_Item_Class * > +elm_genlist_item_class_new(void) > > +EAPI void > +elm_genlist_item_class_free(Elm_Genlist_Item_Class *itc) > > +void > +_elm_genlist_item_class_ref(Elm_Genlist_Item_Class *itc) > > +void > +_elm_genlist_item_class_unref(Elm_Genlist_Item_Class *itc) > > genlist item class is maintained by genlist in automatic manner. > > And three fields are introduced in genlist item class. > + int version; > + unsigned int refcount; > + Eina_Bool delete_me; > > Normally a user add a elm_genlist_item_class by elm_genlist_item_class_new(). > Then its reference counter is automatic maintained. > If the user wanna to remove the elm_genlist_item_class, then call > elm_genlist_item_class_free() > After refcount reaches to 0, it will be removed. > > Thank you. > > PS: I made those apis in genlist. If its accepted i'll make a new > patch for gengrid. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
