On Thu, 16 Feb 2012 14:59:58 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
no - doing this in a hurry and no one uses this... :) > No marks for deprecation? > > Daniel Juyung Seo (SeoZ) > > On Thu, Feb 16, 2012 at 2:58 PM, Enlightenment SVN < > no-re...@enlightenment.org> wrote: > > > Log: > > elm_thumb_ethumb_client_connected -> > > elm_thumb_ethumb_client_connected_get() > > > > more consistent name. > > > > > > > > Author: raster > > Date: 2012-02-15 21:58:23 -0800 (Wed, 15 Feb 2012) > > New Revision: 68001 > > Trac: http://trac.enlightenment.org/e/changeset/68001 > > > > Modified: > > trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_icon.c > > trunk/elementary/src/lib/elm_photo.c trunk/elementary/src/lib/elm_thumb.c > > trunk/elementary/src/lib/elm_thumb.h > > > > Modified: trunk/elementary/src/lib/Elementary.h.in > > =================================================================== > > --- trunk/elementary/src/lib/Elementary.h.in 2012-02-16 05:03:57 UTC > > (rev 68000) > > +++ trunk/elementary/src/lib/Elementary.h.in 2012-02-16 05:58:23 UTC > > (rev 68001) > > @@ -244,7 +244,7 @@ > > #include <elm_spinner.h> // OK > > #include <elm_store.h> // XXX: needs docs > > #include <elm_table.h> // OK > > -#include <elm_theme.h> > > +#include <elm_theme.h> // OK > > #include <elm_thumb.h> > > #include <elm_toolbar.h> > > #include <elm_transit.h> > > > > Modified: trunk/elementary/src/lib/elm_icon.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_icon.c 2012-02-16 05:03:57 UTC (rev 68000) > > +++ trunk/elementary/src/lib/elm_icon.c 2012-02-16 05:58:23 UTC (rev 68001) > > @@ -700,7 +700,7 @@ > > eina_stringshare_replace(&wd->thumb.file.path, file); > > eina_stringshare_replace(&wd->thumb.file.key, group); > > > > - if (elm_thumb_ethumb_client_connected()) > > + if (elm_thumb_ethumb_client_connected_get()) > > { > > _icon_thumb_apply(wd); > > return ; > > > > Modified: trunk/elementary/src/lib/elm_photo.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_photo.c 2012-02-16 05:03:57 UTC > > (rev 68000) > > +++ trunk/elementary/src/lib/elm_photo.c 2012-02-16 05:58:23 UTC > > (rev 68001) > > @@ -591,7 +591,7 @@ > > eina_stringshare_replace(&wd->thumb.file.path, file); > > eina_stringshare_replace(&wd->thumb.file.key, group); > > > > - if (elm_thumb_ethumb_client_connected()) > > + if (elm_thumb_ethumb_client_connected_get()) > > { > > _icon_thumb_apply(wd); > > return ; > > > > Modified: trunk/elementary/src/lib/elm_thumb.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_thumb.c 2012-02-16 05:03:57 UTC > > (rev 68000) > > +++ trunk/elementary/src/lib/elm_thumb.c 2012-02-16 05:58:23 UTC > > (rev 68001) > > @@ -409,7 +409,7 @@ > > { > > evas_object_show(wd->frame); > > > > - if (elm_thumb_ethumb_client_connected()) > > + if (elm_thumb_ethumb_client_connected_get()) > > { > > _thumb_apply(wd); > > return; > > @@ -690,7 +690,7 @@ > > } > > > > EAPI Eina_Bool > > -elm_thumb_ethumb_client_connected(void) > > +elm_thumb_ethumb_client_connected_get(void) > > { > > return _elm_ethumb_connected; > > } > > > > Modified: trunk/elementary/src/lib/elm_thumb.h > > =================================================================== > > --- trunk/elementary/src/lib/elm_thumb.h 2012-02-16 05:03:57 UTC > > (rev 68000) > > +++ trunk/elementary/src/lib/elm_thumb.h 2012-02-16 05:58:23 UTC > > (rev 68001) > > @@ -7,7 +7,7 @@ > > * A thumb object is used for displaying the thumbnail of an image or > > video. > > * You must have compiled Elementary with Ethumb_Client support and the > > DBus > > * service must be present and auto-activated in order to have thumbnails > > to > > - * be generated. > > + * be generated. You must also have a Session bus, not System bus. > > * > > * Once the thumbnail object becomes visible, it will check if there is a > > * previously generated thumbnail image for the file set on it. If not, it > > @@ -126,9 +126,9 @@ > > EAPI void elm_thumb_file_get(const Evas_Object > > *obj, const char **file, const char **key); > > > > /** > > - * Get the path and key to the image or video generated by ethumb. > > + * Get the path and key to the image or video thumbnail generated by > > ethumb. > > * > > - * One just need to make sure that the thumbnail was generated before > > getting > > + * One just needs to make sure that the thumbnail was generated before > > getting > > * its path; otherwise, the path will be NULL. One way to do that is by > > asking > > * for the path when/after the "generate,stop" smart callback is called. > > * > > @@ -225,7 +225,7 @@ > > * @return EINA_TRUE if the client is connected to the server or EINA_FALSE > > * otherwise. > > */ > > -EAPI Eina_Bool elm_thumb_ethumb_client_connected(void); > > +EAPI Eina_Bool > > elm_thumb_ethumb_client_connected_get(void); > > > > /** > > * Make the thumbnail 'editable'. > > > > > > > > ------------------------------------------------------------------------------ > > Virtualization & Cloud Management Using Capacity Planning > > Cloud computing makes use of virtualization - but cloud computing > > also focuses on allowing computing to be delivered as a service. > > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
