On Fri, Feb 24, 2012 at 2:35 AM, Jihoon Kim <[email protected]> wrote: > Hi, > > According to your comments, I've revised patch and I'd like to request a > review prior to applying in svn. > > I referred to elm_ethumb_ethumb_client_get() API. It also returns void * > for avoiding to use "configure defined macro" > > How do you think about this revised patch?
better. Still the NEWS file must be filled too. the documentation should say that: * if ecore_imf was not available when edhe was compiled, that function returns NULL * otherwise, the returned pointer is a Ecore_IMF * Vincent > On Thursday, February 23, 2012, Vincent Torri wrote: > >> On Thu, Feb 23, 2012 at 7:48 AM, Jihoon Kim >> <[email protected]<javascript:;>> >> wrote: >> > I got it. >> > I've reverted. >> > >> > I will send patch in this e-mail thread for reviewing again. >> >> also, if you add a function, at least, update ChangeLog, and better >> update also NEWS >> >> Vincent >> >> > >> > On Thursday, February 23, 2012, Vincent Torri wrote: >> > >> >> On Thu, Feb 23, 2012 at 7:32 AM, David Seikel >> >> <[email protected]<javascript:;> >> <javascript:;>> >> >> wrote: >> >> > On Thu, 23 Feb 2012 07:27:52 +0100 Vincent Torri >> >> > <[email protected] <javascript:;> <javascript:;>> wrote: >> >> > >> >> >> On Thu, Feb 23, 2012 at 7:25 AM, Vincent Torri >> >> >> <[email protected] <javascript:;> <javascript:;>> wrote: >> >> >> > On Thu, Feb 23, 2012 at 7:15 AM, Enlightenment SVN >> >> >> > <[email protected] <javascript:;> <javascript:;>> wrote: >> >> >> >> Log: >> >> >> >> Add edje_object_part_text_imf_context_get API >> >> >> >> This API can be used to get the input method context in entry. >> >> >> >> >> >> >> >> >> >> >> >> Author: jihoon >> >> >> >> Date: 2012-02-22 22:15:12 -0800 (Wed, 22 Feb 2012) >> >> >> >> New Revision: 68306 >> >> >> >> Trac: http://trac.enlightenment.org/e/changeset/68306 >> >> >> >> >> >> >> >> Modified: >> >> >> >> trunk/edje/src/lib/Edje.h trunk/edje/src/lib/edje_entry.c >> >> >> >> trunk/edje/src/lib/edje_private.h trunk/edje/src/lib/edje_util.c >> >> >> >> >> >> >> >> Modified: trunk/edje/src/lib/Edje.h >> >> >> >> >> =================================================================== >> >> >> >> --- trunk/edje/src/lib/Edje.h 2012-02-23 06:13:00 UTC (rev >> 68305) >> >> >> >> +++ trunk/edje/src/lib/Edje.h 2012-02-23 06:15:12 UTC (rev >> 68306) >> >> >> >> @@ -452,6 +452,10 @@ >> >> >> >> # undef EAPI >> >> >> >> #endif >> >> >> >> >> >> >> >> +#ifdef HAVE_ECORE_IMF >> >> >> > >> >> >> > NOOOOO ! NEVER use configure defined macro in public header >> >> >> > files !!! >> >> >> > >> >> >> > Hence he function edje_object_part_text_imf_context_get() below >> must >> >> >> > be always defined. In case there is no ecore_imf, it should just >> >> >> > return NULL >> >> >> >> >> >> or make ecore_imf a hard dependency of edje >> >> > >> >> > NOOOOO, then my embedded project that uses edje but has no need for >> IMF >> >> > gets a bit more bloated. >> >> >> >> then the returned value of the added function must be changed, as it >> >> returns an Ecore_IMF_Context pointer >> >> >> >> Imho, that commit must be reverted until something better is proposed >> >> >> >> Vincent >> >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Virtualization & Cloud Management Using Capacity Planning >> >> Cloud computing makes use of virtualization - but cloud computing >> >> also focuses on allowing computing to be delivered as a service. >> >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ >> >> _______________________________________________ >> >> enlightenment-devel mailing list >> >> [email protected] <javascript:;> <javascript:;> >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> > >> ------------------------------------------------------------------------------ >> > Virtualization & Cloud Management Using Capacity Planning >> > Cloud computing makes use of virtualization - but cloud computing >> > also focuses on allowing computing to be delivered as a service. >> > http://www.accelacomm.com/jaw/sfnl/114/51521223/ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] <javascript:;> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> ------------------------------------------------------------------------------ >> Virtualization & Cloud Management Using Capacity Planning >> Cloud computing makes use of virtualization - but cloud computing >> also focuses on allowing computing to be delivered as a service. >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] <javascript:;> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
