Dear Goun.
I reviewed your code. the feature looked not bad for me.
Here are my comments.
please check them.
1.
EAPI Eina_Bool elm_index_indicator_disabled_get(Evas_Object *obj);
-> Please add the 'const' to the parameter.
2.
in the elm_index_indicator_disabled_set(Evas_Object *obj, Eina_Bool disabled)
function.
please add !! as possible.
-> !!disabled;
and I guess you can return if the value is same.
-> if (wd->hide_button == disabled) return;
It would be better if the internal variable name is "button_disabled"
and end of the function you don't need to return;
3. in _sel_eval function. (original code 410 ~ 425)
It looks it doesn't need to update label, last characters if the button is
disabled.
Thank you.
------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "GoUn Lee"<gouni....@samsung.com>
To:
"enlightenment-devel@lists.sourceforge.net"<enlightenment-devel@lists.sourceforge.net>
Cc:
Sent: 12-02-27(월) 18:05:08
Subject: [E-devel] [Patch] Add new API in Index widget
(elm_index_indicator_disabled_set/get())
Dear Developers,
First of all, sorry for that I sent a patch without any message before. I have
no idea why e-mail was empty even I wrote something..
I hope, this time will work fine.
I've attached patch file about new API in Index widget.
called elm_index_indicator_disabled_set() / elm_index_indicator_disabled_get()
Using this elm_index_indicator_disabled_set API, if it is set EINA_TRUE in
second value, popup text could be invisible.
In this API, indicator notes popup text which shows a letter has been selecting.
I tested through elementary_test, and it works.
Please review this patch.
Thank you.
Goun------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
