2012/3/1 Michael Blumenkrantz <[email protected]>: > On Thu, 01 Mar 2012 13:57:56 +0200 > Tom Hacohen <[email protected]> wrote: > >> Hey, >> >> Toolbar's SHRINK_MENU option doesn't work in general, but there's also a >> new bug that was added recently (last week or so): >> >> Someone broke the separator's theme. Just look at ecrire, you see a >> blank area instead of a vertical separator. Or in other words, FFS CHECK >> YOUR CODE BEFORE YOU COMMIT! >> >> I have no time to look for the offending commit at the moment, but >> please, whoever recently broke toolbar, fix it. >> >> -- >> Tom. > > This is all the result of 68495; I have already reported a large number > of bugs related to it, and I encourage you to continue reporting them as well. >
Naturally, changing from plain Edje objects to a complete Elementary widget as the toolbar buttons will have a lot of unexpected changes in its behavior. If the sole reason for this change was to allow focusing individual buttons in the toolbar, then the best thing to do would be to revert the commit and actually handle focus of individual buttons inside the toolbar by properly using the lot of focus hooks and functions available. There's a reason those are as complex as they are and that's to allow flexibility for widgets that could have several focusable elements within that are not necessarily full blown widgets. > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
